RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE

2025-04-10 Thread Michael Strauß
Fixes the bug that `BitSet.equals(null)` throws NPE. A single reviewer should be sufficient. - Commit messages: - fix equals(null) - failing test Changes: https://git.openjdk.org/jfx/pull/1766/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1766&range=00 Issue: https://

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-10 Thread John Hendrikx
On Wed, 9 Apr 2025 12:27:31 GMT, Ambarish Rapte wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> obj == null > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 540: > >> 538:

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-10 Thread Michael Strauß
On Wed, 9 Apr 2025 18:41:06 GMT, Andy Goryachev wrote: > https://github.com/openjdk/jfx/pull/1766/checks?check_run_id=40273913986 > > this is a weird failure, I've never seen it before. something happened at > cygwin (after yesterday outage) perhaps? > > @mstr2 could you re-run the windows job

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-10 Thread Ambarish Rapte
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null mo

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Kevin Rushforth
On Wed, 9 Apr 2025 19:17:33 GMT, Michael Strauß wrote: > > https://github.com/openjdk/jfx/pull/1766/checks?check_run_id=40273913986 > > this is a weird failure, I've never seen it before. something happened at > > cygwin (after yesterday outage) perhaps? > > @mstr2 could you re-run the windows j

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread John Hendrikx
On Wed, 9 Apr 2025 18:27:12 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with three > additional commits since the last revision: > > - hashSet.equ

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 18:27:12 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with three > additional commits since the last revision: > > - hashSet.equ

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 18:27:12 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with three > additional commits since the last revision: > > - hashSet.equ

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Michael Strauß
> Fixes the bug that `BitSet.equals(null)` throws NPE. > > A single reviewer should be sufficient. Michael Strauß has updated the pull request incrementally with three additional commits since the last revision: - hashSet.equals(bitSet) - review comments - review comments - Cha

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null Ch

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null th

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread John Hendrikx
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null Lo

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Michael Strauß
On Wed, 9 Apr 2025 08:59:37 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> obj == null > > modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/BitSetTest.java > line 50: > >> 48:

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Michael Strauß
> Fixes the bug that `BitSet.equals(null)` throws NPE. > > A single reviewer should be sufficient. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: obj == null - Changes: - all: https://git.openjdk.org/jfx/pull/1766/

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE

2025-04-09 Thread Nir Lisker
On Wed, 9 Apr 2025 07:06:29 GMT, Michael Strauß wrote: > Fixes the bug that `BitSet.equals(null)` throws NPE. > > A single reviewer should be sufficient. modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 536: > 534: return true; > 535: } > 536: