Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

2025-05-13 Thread duke
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> func

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

2025-05-13 Thread Ambarish Rapte
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> func

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

2025-05-07 Thread Andy Goryachev
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> func

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

2025-05-07 Thread Alexander Zuev
On Wed, 7 May 2025 15:43:18 GMT, Andy Goryachev wrote: > so the group protocol is **not** needed for the progress bar/indicator? What? It is required see the definition for the interface: `@interface JFXProgressIndicatorAccessibility : JFXGroupAccessibility` - PR Comment: h

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

2025-05-07 Thread Andy Goryachev
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> func

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

2025-05-07 Thread Andy Goryachev
On Wed, 7 May 2025 15:42:03 GMT, Alexander Zuev wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> func

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol [v2]

2025-05-07 Thread Alexander Zuev
> Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functionality of the code since it has to behave exactly in the s

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-05-05 Thread Andy Goryachev
On Mon, 28 Apr 2025 10:30:34 GMT, Ambarish Rapte wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> fun

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-05-05 Thread Alexander Zuev
On Wed, 30 Apr 2025 21:52:15 GMT, Andy Goryachev wrote: > How can one test the group protocol change? Right now the group protocol is only used as a parent protocol for the composite component such as ProgressBar and the only way to properly test it is to add the debugging output to methods su

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-30 Thread Andy Goryachev
On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote: > Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functio

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-30 Thread Andy Goryachev
On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote: > Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functio

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-30 Thread Andy Goryachev
On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote: > Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functio

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-30 Thread Alexander Zuev
On Mon, 28 Apr 2025 21:25:06 GMT, Andy Goryachev wrote: > Are these changes testable? If so, could you please describe what we are > supposed to see during the testing? This fix covers two controls - ProgressBar and ProgressIndicator, i used Ensemble, it has pages for both with values and just

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-28 Thread Alexander Zuev
On Mon, 28 Apr 2025 10:29:11 GMT, Ambarish Rapte wrote: >> Initial implementation. In order to implement progress indicator the group >> accessibility protocol has to be implemented too so this is also a fix for >> 8351773. There are commented out sections that can be used to verify the >> fun

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-28 Thread Andy Goryachev
On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote: > Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functio

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-28 Thread Victor Dyakov
On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote: > Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functio

Re: RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-28 Thread Ambarish Rapte
On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote: > Initial implementation. In order to implement progress indicator the group > accessibility protocol has to be implemented too so this is also a fix for > 8351773. There are commented out sections that can be used to verify the > functio

RFR: 8350316: Create implementation of NSAccessibilityProgressIndicator protocol

2025-04-27 Thread Alexander Zuev
Initial implementation. In order to implement progress indicator the group accessibility protocol has to be implemented too so this is also a fix for 8351773. There are commented out sections that can be used to verify the functionality of the code since it has to behave exactly in the same way