Re: RFR: 8349255: TitledPane: exception initializing in a background thread [v2]

2025-02-14 Thread Michael Strauß
On Fri, 14 Feb 2025 18:20:53 GMT, Andy Goryachev wrote: >> ## Root Cause >> >> Animation was started in the background thread, causing concurrent access. >> >> ## Solution >> >> Disable animation if not the fx app thread. > > Andy Goryachev has updated the pull request with a new target base d

Re: RFR: 8349255: TitledPane: exception initializing in a background thread [v2]

2025-02-14 Thread Kevin Rushforth
On Fri, 14 Feb 2025 18:20:53 GMT, Andy Goryachev wrote: >> ## Root Cause >> >> Animation was started in the background thread, causing concurrent access. >> >> ## Solution >> >> Disable animation if not the fx app thread. > > Andy Goryachev has updated the pull request with a new target base d

Re: RFR: 8349255: TitledPane: exception initializing in a background thread [v2]

2025-02-14 Thread Andy Goryachev
> ## Root Cause > > Animation was started in the background thread, causing concurrent access. > > ## Solution > > Disable animation if not the fx app thread. Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 27 commits

Re: RFR: 8349255: TitledPane: exception initializing in a background thread [v2]

2025-02-14 Thread Andy Goryachev
On Thu, 13 Feb 2025 18:32:58 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1442: >> >>> 1440: // of this node, since visibility affects >>> bounds of the >>> 1441: // parent node >>> 1442:

Re: RFR: 8349255: TitledPane: exception initializing in a background thread

2025-02-13 Thread Kevin Rushforth
On Wed, 12 Feb 2025 19:10:30 GMT, Andy Goryachev wrote: >> ## Root Cause >> >> Animation was started in the background thread, causing concurrent access. >> >> ## Solution >> >> Disable animation if not the fx app thread. > > modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 14

Re: RFR: 8349255: TitledPane: exception initializing in a background thread

2025-02-13 Thread Kevin Rushforth
On Wed, 12 Feb 2025 19:07:19 GMT, Andy Goryachev wrote: > ## Root Cause > > Animation was started in the background thread, causing concurrent access. > > ## Solution > > Disable animation if not the fx app thread. The fix looks good. I'll test it later. I left one comment about the change in

Re: RFR: 8349255: TitledPane: exception initializing in a background thread

2025-02-12 Thread Andy Goryachev
On Wed, 12 Feb 2025 19:07:19 GMT, Andy Goryachev wrote: > ## Root Cause > > Animation was started in the background thread, causing concurrent access. > > ## Solution > > Disable animation if not the fx app thread. modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1442: > 144

RFR: 8349255: TitledPane: exception initializing in a background thread

2025-02-12 Thread Andy Goryachev
## Root Cause Animation was started in the background thread, causing concurrent access. ## Solution Disable animation if not the fx app thread. - Commit messages: - the fix - Merge branch 'master' into 8349255.thread.safe.titled.pane - Merge branch 'master' into 8349255.thread.