On Fri, 14 Feb 2025 16:23:58 GMT, Kevin Rushforth wrote:
>> Although, having said that, the purpose of the cleanup is to clean up after
>> the animation. So a better fix might be to put the entire if-else inside an
>> `if (Platform.isFxApplicationThread())` test.
>
> Actually, no. It also calls
On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
On Fri, 14 Feb 2025 16:20:33 GMT, Kevin Rushforth wrote:
>> If you mean two threads accessing this same TabPaneSkin instance, then
>> that's not a valid case. JavaFX objects are not thread-safe when accessed
>> from multiple threads. This bug (and the other related bugs fixed or under
>> revie
On Fri, 14 Feb 2025 16:12:27 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
>> line 523:
>>
>>> 521: };
>>> 522:
>>> 523: if (Platform.isFxApplicationThread() &&
>>> (closeTabAnimation.get() == Ta
On Thu, 13 Feb 2025 12:45:20 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> comm
On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
> ## Root Cause
> Animation gets started in a background thread, which causes the animation
> handler to run in the FX application thread, thus creating simultaneous
> access to the control's fields (list of children in this case).
>
> ## Solution
> Skip the animation.
>
> The fix is similar to
On Thu, 6 Feb 2025 23:20:30 GMT, Andy Goryachev wrote:
> ## Root Cause
> Animation gets started in a background thread, which causes the animation
> handler to run in the FX application thread, thus creating simultaneous
> access to the control's fields (list of children in this case).
>
> ##
## Root Cause
Animation gets started in a background thread, which causes the animation
handler to run in the FX application thread, thus creating simultaneous access
to the control's fields (list of children in this case).
## Solution
Skip the animation.
The fix is similar to https://github.co
10 matches
Mail list logo
