Re: RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-13 Thread Kevin Rushforth
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote: > ## Root Cause > > The ContextMenu (PopupWindow) cannot be shown in a background thread. > > ## Solution > > Bail out of `show()` if in a background thread. I took another look today, and I am convinced that we need to change the spec

Re: RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-12 Thread Kevin Rushforth
On Wed, 12 Feb 2025 23:45:55 GMT, Andy Goryachev wrote: > What threw me off is the way javadoc for show() is currently phrased: "popup > aspects" implies something else beyond the simple aspect, for example, it > could be a visible property on a detail pane or selected tab/page. > > Should we

Re: RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-12 Thread Andy Goryachev
On Wed, 12 Feb 2025 23:03:45 GMT, Michael Strauß wrote: > It's not clear to me that invoking actions on a node should count as > "modifying" I agree with this statement. What threw me off is the way javadoc for `show()` is currently phrased: "popup aspects" implies something else beyond the s

Re: RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-12 Thread Kevin Rushforth
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote: > ## Root Cause > > The ContextMenu (PopupWindow) cannot be shown in a background thread. > > ## Solution > > Bail out of `show()` if in a background thread. One more reason to disallow show in this case is that ContextMenu is a descend

Re: RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-12 Thread Kevin Rushforth
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote: > ## Root Cause > > The ContextMenu (PopupWindow) cannot be shown in a background thread. > > ## Solution > > Bail out of `show()` if in a background thread. Let's resolve the general question regarding what to do about the various `*Sk

Re: RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-12 Thread Michael Strauß
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote: > ## Root Cause > > The ContextMenu (PopupWindow) cannot be shown in a background thread. > > ## Solution > > Bail out of `show()` if in a background thread. I'm not convinced that this is the right solution. `Node` says: * Node objec

RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-12 Thread Andy Goryachev
## Root Cause The ContextMenu (PopupWindow) cannot be shown in a background thread. ## Solution Bail out of `show()` if in a background thread. - Commit messages: - split / menu button fix Changes: https://git.openjdk.org/jfx/pull/1709/files Webrev: https://webrevs.openjdk.org/