On Sat, 22 Feb 2025 15:30:24 GMT, Kevin Rushforth wrote:
>> good question! this code exercises both remove and add code paths.
>
> Maybe add a comment then?
added a class-level comment.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1697#discussion_r1970248044
On Mon, 10 Feb 2025 18:41:07 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java
>> line 186:
>>
>>> 184: accessChart(c);
>>> 185: c.getData().setAll(createNumberSeries());
>>> 186: c.getData().se
On Wed, 12 Feb 2025 09:59:30 GMT, Alexander Zuev wrote:
> I am curious why do we make labels in charts focus traversable when a11y is
> switched on?
I think the reason is to announce the axis values for each data point (that's
what the VoiceOver announces on macOS for me) - you can readily try
On Fri, 7 Feb 2025 18:43:32 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Mon, 10 Feb 2025 18:38:00 GMT, Alexander Zuev wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 19 commits:
>>
>> - Merge branch 'master' into 8349091.charts.thread.safety
>> - whitespace
>> - Merge re
On Fri, 7 Feb 2025 18:43:32 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
> Root Cause:
> (Multiple) properties are getting bound to the global
> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
> properties is not thread-safe.
>
> I also changed the design a bit. Originally, every symbol in a chart had its
> `focusTraversableProperty` boun
