Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-04-05 Thread Sergey Nazarkin
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-04-04 Thread Kevin Rushforth
On Fri, 21 Mar 2025 10:54:58 GMT, Sergey Nazarkin wrote: > I see CanvasTest failure. But I guess it is unrelated > > ``` > CanvasTest > testCanvasPattern() FAILED > org.opentest4j.AssertionFailedError: First rect top-left ==> expected: > <255> but was: <0> > ``` @snazarkin This failure is

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-04-04 Thread Kevin Rushforth
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

[jfx24u] RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-24 Thread Jay Bhaskar
A clean backport to jfx24u , the patch fixes current canvas pattern issue where canvas pattern drawing was not working when using svg matrix image. - Commit messages: - Backport fd099a7f067c1694c1c12a8fa02b1e7eda51201f Changes: https://git.openjdk.org/jfx24u/pull/16/files Webrev:

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-24 Thread Ambarish Rapte
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Kevin Rushforth
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Kevin Rushforth
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Sergey Nazarkin
On Fri, 21 Mar 2025 12:40:21 GMT, Kevin Rushforth wrote: > > I see CanvasTest failure. But I guess it is unrelated > > ``` > > CanvasTest > testCanvasPattern() FAILED > > org.opentest4j.AssertionFailedError: First rect top-left ==> expected: > > <255> but was: <0> > > ``` > > @snazarkin Thi

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Sergey Nazarkin
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Jay Bhaskar
Issue: Ref: Webkit 619.1 javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp refactoring in 620.1 In the case of the canvas pattern using a transform property filled with an SVGMatrix() created by an SVG element, `frame.m_nativeImage->size()` calls `NativeImage::size()`