Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs [v2]

2025-01-14 Thread Kevin Rushforth
On Tue, 14 Jan 2025 16:10:00 GMT, Andy Goryachev wrote: >> Found during writing the API tests: >> >> - setUseContentHeight/Width (true -> on) > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > revert nullable change LGTM.

Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs [v2]

2025-01-14 Thread Andy Goryachev
> Found during writing the API tests: > > - setUseContentHeight/Width (true -> on) Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: revert nullable change - Changes: - all: https://git.openjdk.org/jfx/pull/1676/files

Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs [v2]

2025-01-14 Thread Andy Goryachev
On Tue, 14 Jan 2025 15:50:49 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert nullable change > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichT

Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs

2025-01-14 Thread Kevin Rushforth
On Tue, 14 Jan 2025 15:41:38 GMT, Andy Goryachev wrote: > Found during writing the API tests: > > - setUseContentHeight/Width (true -> on) > - remove unnecessary non-nullable limitation for caretBlinkProperty The change to setUseContentWidth / Height is an obviously correct fix. I am not in fa

RFR: 8347715: RichTextArea Follow-up: Minor Bugs

2025-01-14 Thread Andy Goryachev
Found during writing the API tests: - setUseContentHeight/Width (true -> on) - remove unnecessary non-nullable limitation for caretBlinkProperty - Commit messages: - 8347715: RichTextArea Follow-up: Minor Bugs Changes: https://git.openjdk.org/jfx/pull/1676/files Webrev: https://w