> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1677/files
- new: https://git.openjdk.org/jfx/pull/1677/files/
On Wed, 23 Apr 2025 21:23:31 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
Marked as reviewed by kcr (Lead).
-
PR Review: h
On Wed, 23 Apr 2025 18:28:17 GMT, Andy Goryachev wrote:
> beginning, missing, and end
Um, sorry about the typo. I'll blame auto-correct (although it's probably my
fault).
I meant "beginning, **middle**, and end".
Currently you are testing `copy` with the entire paragraph selected. What I was
On Wed, 23 Apr 2025 19:31:16 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 29 commits:
>
> - review comments
> - Merge remote-tracking branch '
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 29 commits:
- review comments
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- rm junit4
- Merge remote
On Tue, 22 Apr 2025 23:09:15 GMT, Kevin Rushforth wrote:
>> hmmm... This pattern was copied from some other test. We have 32 more
>> instances of this pattern elsewhere.
>>
>> I suspect it is not avoid declaring a checked exception.
>> What would you suggest? Forward the `throwable` to
>> `
On Tue, 22 Apr 2025 21:44:33 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Tue, 22 Apr 2025 23:12:37 GMT, Kevin Rushforth wrote:
>> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java
>> line 466:
>>
>>> 464:
>>> 465: @Test
>>> 466: public void modelChangeClearsSelection() {
>>
>> Since the actual d
On Tue, 22 Apr 2025 22:48:43 GMT, Andy Goryachev wrote:
>> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java
>> line 410:
>>
>>> 408: control.setModel(null);
>>> 409: // on second through, maybe this should return null
>
On Tue, 22 Apr 2025 21:37:38 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Wed, 23 Apr 2025 15:17:26 GMT, Andy Goryachev wrote:
>> Unit tests already need to load the JavaFX modules, so I don't see how
>> packaging it in a jar would help. All it would do it add one more thing to
>> put on the path.
>
> I meant the single-file manual tests, continuing discussion in
On Tue, 22 Apr 2025 23:10:56 GMT, Kevin Rushforth wrote:
>> It might, or perhaps it could be packaged into a jar so we can run single
>> source files + library via JEP 458 `--class-path 'libs/*'` argument?
>>
>> see "Using pre-compiled classes" section in
>> https://openjdk.org/jeps/458
>
> Uni
On Tue, 22 Apr 2025 22:40:01 GMT, Andy Goryachev wrote:
>> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/util/TUtil.java
>> line 40:
>>
>>> 38:
>>> 39: /**
>>> 40: * There should be a common place for module-agnostic test utilities.
>>
>> javafx.base might eventually
On Tue, 22 Apr 2025 21:47:31 GMT, Kevin Rushforth wrote:
> Since the actual data is sorted
Typo, I meant "stored"
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2055007843
On Mon, 21 Apr 2025 15:18:02 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 27 commits:
>
> - rm junit4
> - Merge remote-tracking branch 'origin
On Tue, 22 Apr 2025 21:46:02 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Tue, 22 Apr 2025 21:39:27 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Tue, 22 Apr 2025 20:57:46 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Tue, 22 Apr 2025 20:36:55 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Mon, 21 Apr 2025 15:18:02 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 27 commits:
>
> - rm junit4
> - Merge remote-tracking branch 'origin
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 27 commits:
- rm junit4
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'o
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 25 commits:
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'origin/master'
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 24 commits:
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'origin/master'
On Wed, 26 Mar 2025 14:46:07 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 23 commits:
>
> - Merge remote-tracking branch 'origin/master' into 8
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 23 commits:
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'origin/master'
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 22 commits:
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'origin/master'
On Thu, 20 Feb 2025 19:40:42 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 20 commits:
>
> - Merge remote-tracking branch 'origin/master' into 8
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 21 commits:
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'origin/master'
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 20 commits:
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'origin/master'
On Tue, 14 Jan 2025 19:44:01 GMT, Andy Goryachev wrote:
> Additional RichTextArea API tests.
one reviewer is probably fine, but feel free to take a look everyone.
-
PR Comment: https://git.openjdk.org/jfx/pull/1677#issuecomment-2622161782
Additional RichTextArea API tests.
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- Merge remote-tracking branch 'origin/8348736.rta.followup.2' into
8347359.rta.api.tests
- review comments
- Merge remote-tracking branch 'origin/83487
31 matches
Mail list logo
