Re: RFR: 8344906: Simplify Java version parsing in the build file [v2]

2024-11-27 Thread Ambarish Rapte
On Wed, 27 Nov 2024 10:35:18 GMT, Nir Lisker wrote: >> Replaces the manual versions handling with >> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). >> >> Changes: >> * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(Strin

Re: RFR: 8344906: Simplify Java version parsing in the build file [v2]

2024-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2024 10:35:18 GMT, Nir Lisker wrote: >> Replaces the manual versions handling with >> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). >> >> Changes: >> * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(Strin

Re: RFR: 8344906: Simplify Java version parsing in the build file [v2]

2024-11-27 Thread Nir Lisker
> Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)` > and `compareJdkVersion(String, String)`, and replace

Re: RFR: 8344906: Simplify Java version parsing in the build file

2024-11-26 Thread Ambarish Rapte
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote: > Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)`

Re: RFR: 8344906: Simplify Java version parsing in the build file

2024-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2024 06:30:14 GMT, Nir Lisker wrote: > Since the build JDK needs to be up to date anyway, I didn't see it as a > problem. I don't see it as a problem, either. - PR Comment: https://git.openjdk.org/jfx/pull/1647#issuecomment-2500791518

Re: RFR: 8344906: Simplify Java version parsing in the build file

2024-11-25 Thread Nir Lisker
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote: > Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)`

Re: RFR: 8344906: Simplify Java version parsing in the build file

2024-11-25 Thread Kevin Rushforth
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote: > Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)`

Re: RFR: 8344906: Simplify Java version parsing in the build file

2024-11-23 Thread Kevin Rushforth
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote: > Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)`

RFR: 8344906: Simplify Java version parsing in the build file

2024-11-23 Thread Nir Lisker
Replaces the manual versions handling with [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). Changes: * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)` and `compareJdkVersion(String, String)`, and replaced them with

Re: RFR: 8344906: Simplify Java version parsing in the build file

2024-11-23 Thread Nir Lisker
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote: > Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)`