On Mon, 10 Feb 2025 18:42:31 GMT, Nir Lisker wrote:
> 8344367: Fix mistakes in FX API docs
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx/pull/1704#pullrequestreview-2606873109
8344367: Fix mistakes in FX API docs
-
Commit messages:
- Backport 8818ccf8ca883cda49c296ebf6d960c6929a9644
Changes: https://git.openjdk.org/jfx/pull/1704/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1704&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8344367
St
On Mon, 10 Feb 2025 16:51:28 GMT, Nir Lisker wrote:
> Do I need to `/backport` this?
Yes please. `/backport :jfx24`
-
PR Comment: https://git.openjdk.org/jfx/pull/1642#issuecomment-2648826371
On Sat, 8 Feb 2025 19:19:56 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains s
On Sat, 8 Feb 2025 19:19:56 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains s
On Sat, 8 Feb 2025 19:19:56 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains s
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains seven commits:
- Fixed javadoc for internal Node methods
-
On Sat, 25 Jan 2025 07:28:32 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert "
On Sat, 25 Jan 2025 13:44:47 GMT, Kevin Rushforth wrote:
> > I think that this week is a good time to integrate this. The copyright year
> > script should be run after this too.
>
> That sounds good.
>
> @arapte Can you file a JBS task to update the copyright years (some time
> during RDP2)?
On Sat, 25 Jan 2025 07:24:49 GMT, Nir Lisker wrote:
> I think that this week is a good time to integrate this. The copyright year
> script should be run after this too.
That sounds good.
@arapte Can you file a JBS task to update the copyright years (some time during
RDP2)?
-
PR
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment
-
Changes:
- all: https://git.ope
On Fri, 6 Dec 2024 13:09:35 GMT, Michael Strauß wrote:
> cssref.html L2038: ` apples when the mnemonic affordance (typically an
> underscore)`
Didn't notice that this was fixed in a bigger patch.
-
PR Comment: https://git.openjdk.org/jfx/pull/1642#issuecomment-2613823400
On Sat, 25 Jan 2025 07:22:33 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresse
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Revert "Addressed review comment"
This reverts commit 60d4ba92b997be9
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote:
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
cssref.html L2038:
` apples when the mnemonic affordance (typically an underscore)`
-
PR Comment: https://g
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote:
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
The corrections look good to me.
-
Marked as reviewed by mhanl (Committer).
PR Review: https://git.openjdk.org/jfx/
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote:
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
I found some spellchecker to which you give a URL and it finds the mistakes. I
needed it for something else, but then thought it
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote:
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
BTW, did you use IDE for this (and which one)?
Eclipse does highlight spelling errors inline when enabled, but I could not
find
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote:
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
I will wait with integration to see what else can be accumulated until the RDPs.
-
PR Comment: https://git.openjdk.o
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote:
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
thank you for fixing these errors (from a guy who contributed at least one)!
-
Marked as reviewed by angorya (Review
A batch of typo and grammar fixes that were found by the spellchecker.
Integration can wait until RDP 1/2.
-
Commit messages:
- More corrections
- Batch typo fixes
- Fix mistakes in OpenJFX docs
Changes: https://git.openjdk.org/jfx/pull/1642/files
Webrev: https://webrevs.openjd
21 matches
Mail list logo
