On Mon, 9 Dec 2024 13:36:02 GMT, Lukasz Kostyra wrote:
>> This PR removes obsolete permission check methods and fields from
>> Font-related classes.
>>
>> Verified the changes on Windows, did not see any regressions.
>
> Lukasz Kostyra has updated the pull request incrementally with one additio
On Mon, 9 Dec 2024 13:36:02 GMT, Lukasz Kostyra wrote:
>> This PR removes obsolete permission check methods and fields from
>> Font-related classes.
>>
>> Verified the changes on Windows, did not see any regressions.
>
> Lukasz Kostyra has updated the pull request incrementally with one additio
> This PR removes obsolete permission check methods and fields from
> Font-related classes.
>
> Verified the changes on Windows, did not see any regressions.
Lukasz Kostyra has updated the pull request incrementally with one additional
commit since the last revision:
Review fixes
--
On Mon, 9 Dec 2024 12:45:56 GMT, Lukasz Kostyra wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java
>> line 1375:
>>
>>> 1373: if (FontFileWriter.hasTempPermission()) {
>>> 1374: return loadEmbeddedFont0(name, fontStream, size,
>>> regi
On Fri, 6 Dec 2024 16:51:48 GMT, Kevin Rushforth wrote:
>> This PR removes obsolete permission check methods and fields from
>> Font-related classes.
>>
>> Verified the changes on Windows, did not see any regressions.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactor
On Fri, 6 Dec 2024 16:40:14 GMT, Lukasz Kostyra wrote:
> This PR removes obsolete permission check methods and fields from
> Font-related classes.
>
> Verified the changes on Windows, did not see any regressions.
apart from one spot with `loadEmbeddedFont0`, lgtm (code review only)
--
On Fri, 6 Dec 2024 16:40:14 GMT, Lukasz Kostyra wrote:
> This PR removes obsolete permission check methods and fields from
> Font-related classes.
>
> Verified the changes on Windows, did not see any regressions.
I spotted what looks like a bug in `loadEmbeddedFont`. The rest looks good.
modu
This PR removes obsolete permission check methods and fields from Font-related
classes.
Verified the changes on Windows, did not see any regressions.
-
Commit messages:
- Cleanup unused security functions from Font classes
Changes: https://git.openjdk.org/jfx/pull/1659/files
Web
