Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-04-04 Thread Kevin Rushforth
On Tue, 25 Mar 2025 21:46:51 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/text/TextRun.java line >> 45: >> >>> 43: int script; >>> 44: TextSpan span; >>> 45: com.sun.javafx.scene.text.TextLine line; >> >> I recommend an import rather than listi

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-25 Thread Andy Goryachev
On Tue, 25 Mar 2025 18:36:51 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert "fixed bad merge" >> >> This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa. > > modules/java

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-25 Thread Andy Goryachev
On Tue, 25 Mar 2025 17:43:43 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert "fixed bad merge" >> >> This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa. > > modules/java

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-25 Thread Kevin Rushforth
On Tue, 25 Mar 2025 21:41:14 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java >> line 100: >> >>> 98: import test.com.sun.javafx.scene.control.test.RT_22463_Person; >>> 99: >>> 100: /** >> >> Minor: We don't typically use javadoc-

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-25 Thread Kevin Rushforth
On Thu, 6 Mar 2025 16:21:52 GMT, Andy Goryachev wrote: >> Changed the StubTextLayout to use product PrismTextLayout with much >> simplified glyph layout (via stubbed fonts). The new layout assumes all the >> glyphs are squares of font size, while the bold type face produces wider >> glyphs (b

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-06 Thread Marius Hanl
On Thu, 6 Mar 2025 16:21:52 GMT, Andy Goryachev wrote: >> Changed the StubTextLayout to use product PrismTextLayout with much >> simplified glyph layout (via stubbed fonts). The new layout assumes all the >> glyphs are squares of font size, while the bold type face produces wider >> glyphs (b

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-06 Thread Andy Goryachev
> Changed the StubTextLayout to use product PrismTextLayout with much > simplified glyph layout (via stubbed fonts). The new layout assumes all the > glyphs are squares of font size, while the bold type face produces wider > glyphs (by 1 pixel). The default font size has changed from 10 to 12