On Tue, 5 Nov 2024 20:13:58 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unr
On Tue, 5 Nov 2024 20:13:58 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unr
On Tue, 5 Nov 2024 06:45:09 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebEngine.java line 1582:
>
>> 1580:
> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
> `{android,ios}`.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request
On Fri, 1 Nov 2024 15:01:10 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
On Fri, 1 Nov 2024 15:01:10 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
On Fri, 1 Nov 2024 13:26:25 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.web/src/main/java/com/sun/webkit/Utilities.java line 119:
>
>> 117: }
>
> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
> `{android,ios}`.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/16
On Thu, 31 Oct 2024 22:51:24 GMT, Andy Goryachev wrote:
> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
> `{android,ios}`.
Looks good except for one problem that needs to be fixed. I also left a
question inline about removed comment lines.
@arapte Can you be the
On Thu, 31 Oct 2024 23:32:50 GMT, Andy Goryachev wrote:
>> https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/bridge/jni/jsc/JNIUtilityPrivate.cpp#L325-L330
>>
>> All Java methods in `javafx.web` that are named `fwk*` are called by native
>> WebKit code
On Thu, 31 Oct 2024 23:30:03 GMT, Kevin Rushforth wrote:
>> I don't see this private method being called...
>
> https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/bridge/jni/jsc/JNIUtilityPrivate.cpp#L325-L330
>
> All Java methods in `javafx.web` that ar
On Thu, 31 Oct 2024 23:26:12 GMT, Andy Goryachev wrote:
>> Very unlikely, but I'll take a look when fixing
>> [JDK-8342993](https://bugs.openjdk.org/browse/JDK-8342993), since this
>> method is on my list to be modified.
>
> I don't see this private method being called...
https://github.com/op
On Thu, 31 Oct 2024 23:22:32 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/java/com/sun/webkit/Utilities.java line 119:
>>
>>> 117: }
>>> 118:
>>> 119: return MethodHelper.invoke(method, instance, args);
>>
>> I think the whole `fwkInvokeWithContext` method and ass
On Thu, 31 Oct 2024 22:51:24 GMT, Andy Goryachev wrote:
> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
> `{android,ios}`.
modules/javafx.web/src/main/java/com/sun/webkit/Utilities.java line 119:
> 117: }
> 118:
> 119: return MethodHelper.invoke(
Removes `doPrivileged` calls in the javafx.web module, excluding the code in
`{android,ios}`.
-
Commit messages:
- web
Changes: https://git.openjdk.org/jfx/pull/1620/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1620&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
On Thu, 31 Oct 2024 22:52:21 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> modules/javafx.web/src/main/java/com/sun/webkit/Utilities.java line 119:
>
>> 117: }
>> 118:
>> 119: return MethodHelp
16 matches
Mail list logo
