On Thu, 31 Oct 2024 15:01:41 GMT, Glavo wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassViewEventHandler.java
> line 69:
On Wed, 30 Oct 2024 20:43:07 GMT, Kevin Rushforth wrote:
>> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
>> `javafx.graphics` module.
>>
>> Here is a quick overview of what I did for this fix:
>>
>> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) ()
On Wed, 30 Oct 2024 22:51:30 GMT, Kevin Rushforth wrote:
>> This looks useful.
>> I wonder if it would make sense to create a utility method in some common
>> Util class?
>>
>>
>> public static boolean initBoolean(BooleanSupplier c) { return
>> c.getAsBoolean(); }
>>
>>
>> edit:
>> maybe in
On Wed, 30 Oct 2024 20:43:07 GMT, Kevin Rushforth wrote:
>> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
>> `javafx.graphics` module.
>>
>> Here is a quick overview of what I did for this fix:
>>
>> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) ()
On Wed, 30 Oct 2024 20:44:39 GMT, Andy Goryachev wrote:
>> I decided to make this change. Thanks for the suggestion.
>
> This looks useful.
> I wonder if it would make sense to create a utility method in some common
> Util class?
>
>
> public static boolean initBoolean(BooleanSupplier c) { ret
On Wed, 30 Oct 2024 20:43:07 GMT, Kevin Rushforth wrote:
>> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
>> `javafx.graphics` module.
>>
>> Here is a quick overview of what I did for this fix:
>>
>> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) ()
On Wed, 30 Oct 2024 20:40:01 GMT, Kevin Rushforth wrote:
>> That's an interesting suggestion: trading a new method for a lambda (the
>> prior code used a lambda to pass to the doPrivileged, so it's also less of a
>> delta). I'll take a look at it and see if it looks better to me.
>
> I decided
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
> LAMBDA)` to `LAMBDA`, removing the `@SuppressWarnings("rem
On Tue, 29 Oct 2024 22:46:30 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java
>> line 142:
>>
>>> 140:
>>> 141: private static final boolean multithreaded = initMultithreaded();
>>> 142: private static boolean initMultit
On Tue, 29 Oct 2024 00:56:27 GMT, Michael Strauß wrote:
>> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
>> `javafx.graphics` module.
>>
>> Here is a quick overview of what I did for this fix:
>>
>> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) ()
On Wed, 23 Oct 2024 20:10:02 GMT, Kevin Rushforth wrote:
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
>
On Wed, 23 Oct 2024 20:10:02 GMT, Kevin Rushforth wrote:
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
>
On Wed, 23 Oct 2024 20:10:02 GMT, Kevin Rushforth wrote:
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
>
This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
`javafx.graphics` module.
Here is a quick overview of what I did for this fix:
1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
LAMBDA)` to `LAMBDA`, removing the `@SuppressWarnings("removal")` if pos
14 matches
Mail list logo
