On Fri, 22 Nov 2024 21:33:37 GMT, Kevin Rushforth wrote:
>> I'd review that! The only question is how to do RT- efficiently, so it can
>> be easily reviewed (without going through manually copying and pasting every
>> id)...
>
> It would be pretty easy to do it with a JIRA REST query: Given an
On Fri, 22 Nov 2024 21:21:34 GMT, Andy Goryachev wrote:
>> That is correct. I still think it's worth it, especially since not everyone
>> knows the 'trick' of pasting the `RT-` entry into the bug tracker to get the
>> corresponding `JDK-` entry (in fact, I only learned that this year 😄)
>
> I'd
On Fri, 22 Nov 2024 21:13:42 GMT, Marius Hanl wrote:
>> and maybe fix the RT- references as well, though it might be a bit harder
>> because a lookup is required.
>
> That is correct. I still think it's worth it, especially since not everyone
> knows the 'trick' of pasting the `RT-` entry into
On Fri, 22 Nov 2024 18:09:07 GMT, Andy Goryachev wrote:
>> maybe we we should do a small cleanup ticket where we replace all `JBS-` and
>> `RT-` references with the `JDK-` one? A quick check led to around 120
>> occurrences.
>
> and maybe fix the RT- references as well, though it might be a bit
On Fri, 22 Nov 2024 18:05:36 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java
>> line 641:
>>
>>> 639:
>>> 640: final CheckMenuItem _item = item;
>>> 641: // fake bidrectional binding (a real one was used her
On Mon, 18 Nov 2024 16:13:35 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8341687: Add more tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java
> lin
On Fri, 22 Nov 2024 17:10:32 GMT, Marius Hanl wrote:
>> There are multiple issues in the `TableMenu` logic that result in a memory
>> leak.
>>
>> The following problems are now fixed with this PR:
>> - The listener, that is registered to the `col.visibleProperty()` was not
>> weak nor was it e
On Mon, 18 Nov 2024 20:21:29 GMT, Andy Goryachev wrote:
>> I tried, but it isn't that easy - since the memory is not leaked because we
>> keep some references we should not keep - rather we are adding listener
>> again and again and again. So we can not assert things to be collectable, as
>> t
> There are multiple issues in the `TableMenu` logic that result in a memory
> leak.
>
> The following problems are now fixed with this PR:
> - The listener, that is registered to the `col.visibleProperty()` was not
> weak nor was it ever unregistered
>- The fix is to do pretty much the same
On Mon, 18 Nov 2024 16:19:20 GMT, Andy Goryachev wrote:
>> There are multiple issues in the `TableMenu` logic that result in a memory
>> leak.
>>
>> The following problems are now fixed with this PR:
>> - The listener, that is registered to the `col.visibleProperty()` was not
>> weak nor was i
On Mon, 18 Nov 2024 20:11:50 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableViewTableHeaderRowTest.java
>> line 261:
>>
>>> 259: /**
>>> 260: * Tests that toggling the column visibility does not cause memory
>>> leaks.
>>> 261:
On Sat, 16 Nov 2024 00:58:47 GMT, Marius Hanl wrote:
> There are multiple issues in the `TableMenu` logic that result in a memory
> leak.
>
> The following problems are now fixed with this PR:
> - The listener, that is registered to the `col.visibleProperty()` was not
> weak nor was it ever un
There are multiple issues in the `TableMenu` logic that result in a memory leak.
The following problems are now fixed with this PR:
- The listener, that is registered to the `col.visibleProperty()` was not weak
nor was it ever unregistered
- The fix is to do pretty much the same that was alrea
13 matches
Mail list logo
