Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v9]

2025-04-10 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-10 Thread Ambarish Rapte
On Sat, 5 Apr 2025 05:27:40 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v8]

2025-04-09 Thread Andy Goryachev
On Mon, 7 Apr 2025 12:26:33 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v11]

2025-04-08 Thread Andy Goryachev
On Tue, 8 Apr 2025 07:42:36 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v11]

2025-04-08 Thread Andy Goryachev
On Tue, 8 Apr 2025 07:42:36 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v10]

2025-04-08 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v11]

2025-04-08 Thread Ambarish Rapte
On Tue, 8 Apr 2025 07:42:36 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v11]

2025-04-08 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v10]

2025-04-07 Thread Ambarish Rapte
On Tue, 8 Apr 2025 03:32:43 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v9]

2025-04-07 Thread Andy Goryachev
On Mon, 7 Apr 2025 17:23:53 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v8]

2025-04-07 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v7]

2025-04-07 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v4]

2025-04-05 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request with a new target base due to a merge or a rebase. The incrementa

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-05 Thread Jay Bhaskar
On Sat, 5 Apr 2025 05:27:40 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-04 Thread Jay Bhaskar
On Fri, 4 Apr 2025 17:09:20 GMT, Andy Goryachev wrote: >> Jay Bhaskar has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - remove whitespace >> - change according to review > > modules/javafx.base/src/test/java/test/javafx/util/converter/D

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v5]

2025-04-04 Thread Jay Bhaskar
On Fri, 4 Apr 2025 17:08:25 GMT, Andy Goryachev wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-order imports > > modules/javafx.base/src/test/java/test/javafx/util/converter/DateTimeStringConverterTest.java > l

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v4]

2025-04-04 Thread Jay Bhaskar
On Fri, 4 Apr 2025 17:04:26 GMT, Andy Goryachev wrote: >> Jay Bhaskar has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-04 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with two additional commits since the last revision

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v5]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 06:08:28 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5

2025-04-04 Thread Andy Goryachev
On Thu, 3 Apr 2025 12:34:37 GMT, Jay Bhaskar wrote: > Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. First batch of comments (up until `ObservableArrayTes

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v5]

2025-04-03 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v3]

2025-04-03 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v2]

2025-04-03 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5

2025-04-03 Thread Ambarish Rapte
On Thu, 3 Apr 2025 12:34:37 GMT, Jay Bhaskar wrote: > Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Providing a few minor comments. modules/javafx.base/

RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5

2025-04-03 Thread Jay Bhaskar
Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing deprecated APIs, updating assertions, and refactoring test structures to align with JUnit 5's improved features. - Commit messages: - remove trailing white space - 8340464: [TestBug] Convert parametrized base te