On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's widt
On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's widt
On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's widt
On Wed, 21 May 2025 05:09:28 GMT, Ambarish Rapte wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid re-layout items twice after disclosure node width value updated
>
> modules/javafx.controls/src/main/java/ja
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
On Tue, 20 May 2025 15:53:53 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's widt
On Tue, 20 May 2025 15:53:53 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's widt
On Tue, 20 May 2025 17:53:54 GMT, Andy Goryachev wrote:
>> Yes, the cells after disclosure node use the new `defaultDisclosureWidth`.
>> But their layout happens twice using the new `defaultDisclosureWidth`.
>>
>> **First time**: The loop `for (IndexedCell cell : flow.cells) {` initiates
>> th
On Tue, 20 May 2025 09:35:45 GMT, Ambarish Rapte wrote:
>>> Would it be possible to avoid re-layout of the cells that are after the
>>> Cell with a disclosureNode ?
>>
>> This is actually what is happening, when we scroll down and find a TreeCell
>> that has a disclosure node this is when the
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
On Thu, 15 May 2025 11:49:45 GMT, Ziad El Midaoui
wrote:
>>> This would perform a layout of all cells, re-layout of previous cells and
>>> layout of next cells. but, layout of next cells is performed again as
>>> continuation layout of TreeView. A solution would be to break the loop when
>>>
On Thu, 15 May 2025 07:07:07 GMT, Ambarish Rapte wrote:
> Would it be possible to avoid re-layout of the cells that are after the Cell
> with a disclosureNode ?
This is actually what is happening, when we scroll down and find a TreeCell
that has a disclosure node this is when the condition `di
On Wed, 14 May 2025 18:26:23 GMT, Ziad El Midaoui
wrote:
>> this is the expected behavior though, right?
>>
>> what we **don't** want is the flicker - when the re-layout is needed but
>> happens in another pulse. When e.g. scrollbars need to appear/disappear it
>> may even lead to flicker th
On Wed, 14 May 2025 17:27:59 GMT, Andy Goryachev wrote:
>>> does this create any visual artifacts?
>>
>> No artifacts, just that one can notice the re-layout and the TreeCell shift
>> to right.
>
> this is the expected behavior though, right?
>
> what we **don't** want is the flicker - when th
On Wed, 14 May 2025 16:40:36 GMT, Ambarish Rapte wrote:
>>> In that case the TreeCells are layout while the scroll is in progress.
>>
>> does this create any visual artifacts?
>
>> does this create any visual artifacts?
>
> No artifacts, just that one can notice the re-layout and the TreeCell s
On Wed, 14 May 2025 15:14:42 GMT, Andy Goryachev wrote:
> does this create any visual artifacts?
No artifacts, just that one can notice the re-layout and the TreeCell shift to
right.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1715#discussion_r2089341995
On Wed, 14 May 2025 14:43:05 GMT, Ziad El Midaoui
wrote:
>> Also noticed a scenario: When a TreeCell with disclosureNode is currently
>> not shown on screen but becomes visible on scrolling. In that case the
>> TreeCells are layout while the scroll is in progress. I see only one way to
>> avo
On Wed, 14 May 2025 14:28:23 GMT, Ambarish Rapte wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
>> line 232:
>>
>>> 230: cell.layout();
>>> 231: }
>>> 232: }
>>
>> T
On Wed, 14 May 2025 14:02:06 GMT, Ambarish Rapte wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update TreeCellSkin.java
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
>
On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
On Wed, 7 May 2025 23:09:51 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update TreeCellSkin.java
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
> l
On Thu, 8 May 2025 20:16:12 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
On Thu, 8 May 2025 15:03:25 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed minor issues and added test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.
On Wed, 7 May 2025 15:56:57 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
On Thu, 8 May 2025 14:59:40 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
On Wed, 7 May 2025 15:56:57 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
On Wed, 19 Feb 2025 16:45:54 GMT, Ziad El Midaoui
wrote:
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
On Wed, 19 Feb 2025 16:45:54 GMT, Ziad El Midaoui
wrote:
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
The issue occurred because items preceding an item with children (items with a
disclosure node) had different widths, which led to misalignment. This can be
fixed by requesting a cell relayout whenever the disclosure node's width
changes.
-
Commit messages:
- Fixed import error
-
35 matches
Mail list logo
