Re: RFR: 8339726: Remove pausing code (used for testing) from AbstractPrimaryTimer

2024-09-10 Thread Marius Hanl
On Mon, 9 Sep 2024 06:23:02 GMT, John Hendrikx wrote: > This PR removes the pausing logic from AbstractPrimaryTimer. The test that > is using it wasn't actually testing anything in AbstractPrimaryTimer itself, > and no other code needs this pausing code. Looks good to me too and always good t

Re: RFR: 8339726: Remove pausing code (used for testing) from AbstractPrimaryTimer

2024-09-09 Thread Kevin Rushforth
On Mon, 9 Sep 2024 06:23:02 GMT, John Hendrikx wrote: > This PR removes the pausing logic from AbstractPrimaryTimer. The test that > is using it wasn't actually testing anything in AbstractPrimaryTimer itself, > and no other code needs this pausing code. Good cleanup. Without digging a bit mo

Re: RFR: 8339726: Remove pausing code (used for testing) from AbstractPrimaryTimer

2024-09-09 Thread Michael Strauß
On Mon, 9 Sep 2024 06:23:02 GMT, John Hendrikx wrote: > This PR removes the pausing logic from AbstractPrimaryTimer. The test that > is using it wasn't actually testing anything in AbstractPrimaryTimer itself, > and no other code needs this pausing code. Looks good. - Marked as

Re: RFR: 8339726: Remove pausing code (used for testing) from AbstractPrimaryTimer

2024-09-09 Thread Andy Goryachev
On Mon, 9 Sep 2024 06:23:02 GMT, John Hendrikx wrote: > This PR removes the pausing logic from AbstractPrimaryTimer. The test that > is using it wasn't actually testing anything in AbstractPrimaryTimer itself, > and no other code needs this pausing code. nice cleanup! - Marked a

RFR: 8339726: Remove pausing code (used for testing) from AbstractPrimaryTimer

2024-09-09 Thread John Hendrikx
This PR removes the pausing logic from AbstractPrimaryTimer. The test that is using it wasn't actually testing anything in AbstractPrimaryTimer itself, and no other code needs this pausing code. - Commit messages: - Remove unused code Changes: https://git.openjdk.org/jfx/pull/155