[jfx23] RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-20 Thread Phil Race
Backport the fix for a crash - Commit messages: - Backport 269d6897e4d4e62beff3a2179dcdabe8a0bf0bc7 Changes: https://git.openjdk.org/jfx/pull/1540/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1540&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338478 Stats: 87

Re: [jfx23] RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-20 Thread Kevin Rushforth
On Tue, 20 Aug 2024 16:34:27 GMT, Phil Race wrote: > Backport the fix for a crash LGTM - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1540#pullrequestreview-2248568996

Re: RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-19 Thread Ambarish Rapte
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote: > The test in the bug report crashes reliably with JDK 22 on retina. > It coincides with an update to the macOS compilers which seem likely to > eagerly invalidate the target of a CFRelease on the native CTFontRef. > Adding a ReachabilityFence t

Re: RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-19 Thread Kevin Rushforth
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote: > The test in the bug report crashes reliably with JDK 22 on retina. > It coincides with an update to the macOS compilers which seem likely to > eagerly invalidate the target of a CFRelease on the native CTFontRef. > Adding a ReachabilityFence t

Re: RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-19 Thread Kevin Rushforth
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote: > The test in the bug report crashes reliably with JDK 22 on retina. > It coincides with an update to the macOS compilers which seem likely to > eagerly invalidate the target of a CFRelease on the native CTFontRef. > Adding a ReachabilityFence t

RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-17 Thread Phil Race
The test in the bug report crashes reliably with JDK 22 on retina. It coincides with an update to the macOS compilers which seem likely to eagerly invalidate the target of a CFRelease on the native CTFontRef. Adding a ReachabilityFence to prevent the GC from collecting CTFontStrike until after th