Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-25 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. This is probably

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-19 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. The problem is th

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-19 Thread Marius Hanl
On Mon, 19 Aug 2024 00:06:07 GMT, Thiago Milczarek Sayao wrote: > It always failing for me, with this PR or without. Since I wrote them, maybe we can fix those tests for you as well and make them more stable across Linux. I think generally those tests are good to have as they can catch serious

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 20:28:20 GMT, Kevin Rushforth wrote: > This causes a regression on Ubuntu 22.04. The following tests fail with this > fix (they all pass with current master), when using X.org or Wayland: > > ``` > SizeToSceneTest > testInitialSizeOnFullscreenThenSizeToScene() FAILED > o

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-18 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. The problem is a

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-16 Thread Kevin Rushforth
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. This causes a reg

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-07 Thread Lukasz Kostyra
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. LGTM, fixes the p

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-01 Thread Kevin Rushforth
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. I've noticed a fe

RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-07-29 Thread Thiago Milczarek Sayao
On Ubuntu 24.04 with Xorg windows are not shown centered. This is due a configure event being received with position 0,0 which is wrong. The fix ignores the configure events until the window is mapped. - Commit messages: - 8337400: [Linux] Initial window position is not centered on