Re: RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-18 Thread duke
On Wed, 17 Jul 2024 05:53:45 GMT, ANUPAM DEV wrote: > Hello, > > There was a typo in the documentation of TreeTableView. > I have changed TreeTableColumns to TreeTableColumn > > Please review. > > Regards, > Anupam @anupamdev20 Your change (at version 61ae9ca55d73d5b4e72c4e5d414310a1c2b328a2

Re: RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-18 Thread Kevin Rushforth
On Thu, 18 Jul 2024 03:02:06 GMT, ANUPAM DEV wrote: >> you may want to configure github actions for this repository - see >> https://wiki.openjdk.org/display/SKARA/Testing > > Thankyou @andy-goryachev-oracle . > I have configured the github actions. > The tests have passed. @anupamdev20 This PR

Re: RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-17 Thread ANUPAM DEV
On Wed, 17 Jul 2024 14:42:43 GMT, Andy Goryachev wrote: >> Hello, >> >> There was a typo in the documentation of TreeTableView. >> I have changed TreeTableColumns to TreeTableColumn >> >> Please review. >> >> Regards, >> Anupam > > you may want to configure github actions for this repository -

Re: RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-17 Thread Andy Goryachev
On Wed, 17 Jul 2024 05:53:45 GMT, ANUPAM DEV wrote: > Hello, > > There was a typo in the documentation of TreeTableView. > I have changed TreeTableColumns to TreeTableColumn > > Please review. > > Regards, > Anupam thank you for finding and fixing this documentation issue! you may want to co

RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-16 Thread ANUPAM DEV
Hello, There was a typo in the documentation of TreeTableView. I have changed TreeTableColumns to TreeTableColumn Please review. Regards, Anupam - Commit messages: - Update TreeTableView.java Changes: https://git.openjdk.org/jfx/pull/1510/files Webrev: https://webrevs.openjdk.o

RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-16 Thread ANUPAM DEV
Hello, There is a typo in TreeTableView.java documentation. TreeTableColumns is used instead of TreeTableColumn. I have updated the below lines: TreeTableColumn fileNameCol = new TreeTableColumn<>("Filename"); TreeTableColumn sizeCol = new TreeTableColumn<>("Size"); Please review. ---