On Wed, 17 Jul 2024 12:21:59 GMT, Kevin Rushforth wrote:
> Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
forgot to mention: checked the target branch is jfx23
-
PR Comment: https://git.openjdk.org/jfx/pull/1511#issuecomment-2234396795
On Wed, 17 Jul 2024 12:21:59 GMT, Kevin Rushforth wrote:
> Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
lgtm
-
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1511#pullrequestreview-2184019091
On Wed, 17 Jul 2024 12:21:59 GMT, Kevin Rushforth wrote:
> Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
Reviewer: @andy-goryachev-oracle
(as it is a clean backport, a single Reviewer will suffiice)
-
PR Comment: https://git.openjdk.org/jfx/pull/15
Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
-
Commit messages:
- Backport 81f11c4a39eb505d17c57a49c5e084f75a169856
Changes: https://git.openjdk.org/jfx/pull/1511/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1511&range=00
Issue: https:/
> This PR solves two related bugs that are caused by events being delivered
> while the FX runtime is in the process of shutting down. These bugs are
> related enough that I think they need to be addressed at the same time. While
> debugging and developing the test, I saw one or the other or bot
On Mon, 15 Jul 2024 19:36:43 GMT, Kevin Rushforth wrote:
> This PR solves two related bugs that are caused by events being delivered
> while the FX runtime is in the process of shutting down. These bugs are
> related enough that I think they need to be addressed at the same time. While
> debug
On Mon, 15 Jul 2024 23:31:43 GMT, Kevin Rushforth wrote:
>>> since all accesses are happening on the FX app thread
>>
>> Not quite right: the following threads access the field, apart from JavaFX
>> Application Thread:
>>
>>
>> thread=JavaFX-Launcher
>> thread=Thread-2
>> thread=PulseTimer-CV
On Mon, 15 Jul 2024 23:03:10 GMT, Andy Goryachev wrote:
>> This is unrelated to the current bug, since all accesses are happening on
>> the FX app thread, so I'd like to file a follow-up to look into this.
>>
>> To answer the question, there might be a potential problem with other
>> threads n
On Mon, 15 Jul 2024 22:53:52 GMT, Kevin Rushforth wrote:
> since all accesses are happening on the FX app thread
Not quite right: the following threads access the field, apart from JavaFX
Application Thread:
thread=JavaFX-Launcher
thread=Thread-2
thread=PulseTimer-CVDisplayLink thread
thread=
On Mon, 15 Jul 2024 22:34:27 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/View.java line 533:
>>
>>> 531: private boolean shouldHandleEvent() {
>>> 532: // Don't send any more events if the application has shutdown
>>> 533: if (Applicat
On Mon, 15 Jul 2024 22:08:12 GMT, Andy Goryachev wrote:
>> This PR solves two related bugs that are caused by events being delivered
>> while the FX runtime is in the process of shutting down. These bugs are
>> related enough that I think they need to be addressed at the same time.
>> While de
On Mon, 15 Jul 2024 19:36:43 GMT, Kevin Rushforth wrote:
> This PR solves two related bugs that are caused by events being delivered
> while the FX runtime is in the process of shutting down. These bugs are
> related enough that I think they need to be addressed at the same time. While
> debug
This PR solves two related bugs that are caused by events being delivered while
the FX runtime is in the process of shutting down. These bugs are related
enough that I think they need to be addressed at the same time. While debugging
and developing the test, I saw one or the other or both in var
13 matches
Mail list logo
