On Sat, 27 Jan 2024 18:09:47 GMT, Nir Lisker wrote:
> By the way, [code snippets](https://openjdk.org/jeps/413) brought a solution
> to this with external snippets. The example code exists in a standard
> compiled java file, whose contents can be referenced in the docs.
True, but we can't use
On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr wrote:
> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
By the way, [code snippets](https://openjdk.org/jeps/413) brought a solution to
this with external snippets. The example code exists in a standard compiled
java
On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr wrote:
> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx/pull/1325#pullrequestreview-1847141169
On Sat, 27 Jan 2024 15:45:36 GMT, Philippe Altherr wrote:
>> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
>
> I have enabled workflows. I have also filed an issue but it looks like this
> will go through a review of its own: review ID : 9076496 :-( In retrospect, I
>
On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr wrote:
> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
Marked as reviewed by jhendrikx (Committer).
-
PR Review: https://git.openjdk.org/jfx/pull/1325#pullrequestreview-1847140605
On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr wrote:
> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
If I can file the bug, I'm glad to do it.
It's a tiny bug. I noticed it while looking into Java FX for a new project. As
I had no experience of FX, it wasn't imm
On Sat, 27 Jan 2024 16:56:40 GMT, Kevin Rushforth wrote:
> You can update this PR title with the bug ID
And change the title to match. So:
8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
-
PR Comment: https://git.openjdk.org/jfx/pull/1325#issuecomment-191
On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr wrote:
> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
I don't mind the change, but there is nothing wrong with it as far as I can
see. `ObservableValue` is used for the types as we're documenting
`ObservableValue`.
8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
-
Commit messages:
- Fix type of variables in code example from ObservableValue to Property.
Changes: https://git.openjdk.org/jfx/pull/1325/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1325&range=00
On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr wrote:
> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
@paltherr Good catch. This needs a JBS bug ID. Maybe @hjohn would help sponsor
this for you (in which case he could create the doc bug)?
See the [CONTRIBUTING
On Sat, 27 Jan 2024 15:23:50 GMT, Philippe Altherr wrote:
>> 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
>
> I did a quick search to see if there other instances of the same problem
> under [jfx/modules...](https://github.com/openjdk/jfx/blob/master/modules/).
> I d
11 matches
Mail list logo
