Re: RFR: 8324232: KeyEvent.getCode() is null inside JFXPanel

2024-06-14 Thread Kevin Rushforth
On Sat, 1 Jun 2024 19:01:21 GMT, Martin Fox wrote: >> Which key is it that causes this? There is a ticket >> https://bugs.openjdk.org/browse/JDK-8090319 that suggests completing the >> missing key codes is also an option. > >> Which key is it that causes this? There is a ticket >> https://bug

Re: RFR: 8324232: KeyEvent.getCode() is null inside JFXPanel

2024-06-12 Thread Andy Goryachev
On Sat, 1 Jun 2024 18:15:56 GMT, Martin Fox wrote: > JavaFX uses a table to map from an AWT integer key code to a JavaFX KeyCode. > If AWT provides a code that's not in the table JavaFX attempts to use a > KeyCode of null when constructing the KeyEvent which raises an exception. > This PR jus

Re: RFR: 8324232: KeyEvent.getCode() is null inside JFXPanel

2024-06-12 Thread Andy Goryachev
On Sat, 1 Jun 2024 18:15:56 GMT, Martin Fox wrote: > JavaFX uses a table to map from an AWT integer key code to a JavaFX KeyCode. > If AWT provides a code that's not in the table JavaFX attempts to use a > KeyCode of null when constructing the KeyEvent which raises an exception. > This PR jus

Re: RFR: 8324232: KeyEvent.getCode() is null inside JFXPanel

2024-06-12 Thread Kevin Rushforth
On Sat, 1 Jun 2024 18:15:56 GMT, Martin Fox wrote: > JavaFX uses a table to map from an AWT integer key code to a JavaFX KeyCode. > If AWT provides a code that's not in the table JavaFX attempts to use a > KeyCode of null when constructing the KeyEvent which raises an exception. > This PR jus

Re: RFR: 8324232: KeyEvent.getCode() is null inside JFXPanel

2024-06-01 Thread Martin Fox
On Sat, 1 Jun 2024 18:38:16 GMT, John Hendrikx wrote: > Which key is it that causes this? There is a ticket > https://bugs.openjdk.org/browse/JDK-8090319 that suggests completing the > missing key codes is also an option. The original bug report was for letter keys on layouts that don't genera

Re: RFR: 8324232: KeyEvent.getCode() is null inside JFXPanel

2024-06-01 Thread John Hendrikx
On Sat, 1 Jun 2024 18:15:56 GMT, Martin Fox wrote: > JavaFX uses a table to map from an AWT integer key code to a JavaFX KeyCode. > If AWT provides a code that's not in the table JavaFX attempts to use a > KeyCode of null when constructing the KeyEvent which raises an exception. > This PR jus

RFR: 8324232: KeyEvent.getCode() is null inside JFXPanel

2024-06-01 Thread Martin Fox
JavaFX uses a table to map from an AWT integer key code to a JavaFX KeyCode. If AWT provides a code that's not in the table JavaFX attempts to use a KeyCode of null when constructing the KeyEvent which raises an exception. This PR just checks for null and changes it to KeyCode.UNDEFINED. -