Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-08-03 Thread Marius Hanl
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote: > This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' > the cells. This actually has nothing to do with the `TitledPane`, but it > triggered the bug easily due to its nature to change the size of his content > when

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-08-01 Thread Kevin Rushforth
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote: > This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' > the cells. This actually has nothing to do with the `TitledPane`, but it > triggered the bug easily due to its nature to change the size of his content > when

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-30 Thread Andy Goryachev
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote: > This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' > the cells. This actually has nothing to do with the `TitledPane`, but it > triggered the bug easily due to its nature to change the size of his content > when

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-30 Thread Andy Goryachev
On Tue, 30 Jul 2024 07:01:58 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 808: >> >>> 806: vertical = new BooleanPropertyBase(true) { >>> 807: @Override protected void invalidated() { >>> 808:

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-30 Thread Marius Hanl
On Mon, 29 Jul 2024 22:00:39 GMT, Andy Goryachev wrote: >> This PR fixes a bug where a `TableView` inside a `TitledPane` may >> 'duplicate' the cells. This actually has nothing to do with the >> `TitledPane`, but it triggered the bug easily due to its nature to change >> the size of his conten

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Andy Goryachev
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote: > This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' > the cells. This actually has nothing to do with the `TitledPane`, but it > triggered the bug easily due to its nature to change the size of his content > when

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Marius Hanl
On Mon, 29 Jul 2024 19:21:03 GMT, Andy Goryachev wrote: > Does this change affect `TreeView`? All components that use the `VirtualFlow`, but it might be more noticeable for some than others. In fact, I first noticed this behavior in `Dialog`s. I will add a reproducer for that one ticket as we

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Andy Goryachev
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote: > This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' > the cells. This actually has nothing to do with the `TitledPane`, but it > triggered the bug easily due to its nature to change the size of his content > when

RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Marius Hanl
This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' the cells. This actually has nothing to do with the `TitledPane`, but it triggered the bug easily due to its nature to change the size of his content when collapsing. The expansion change of a `TitledPane` triggered a