On Tue, 17 Oct 2023 09:23:16 GMT, Florian Kirmaier
wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with th
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier
wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with th
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier
wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with th
On Tue, 19 Sep 2023 22:26:31 GMT, Phil Race wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with the conclu
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier
wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with th
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier
wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with th
On Tue, 31 Oct 2023 11:46:57 GMT, Florian Kirmaier
wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially
>> problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with th
On Thu, 26 Oct 2023 01:51:52 GMT, Michael Strauß wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8316518
>> small change based on codereview
>
> modules/javafx.graphics/src/main/java/javafx/print/Paper.ja
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conclusion (me and John Hendrix) that
> is best to just fix this
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 17 Oct 2023 09:23:16 GMT, Florian Kirmaier
wrote:
> It would be nice if something could be decided here.
>
> Another option would be, to rename the current method to something like
> getWidthInPoints() which then can be used internally. But the old - now
> correct methods - can be exp
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Sat, 23 Sep 2023 06:02:14 GMT, John Hendrikx wrote:
>> About the rounding; all these values are fixed values and could have been
>> entered in points as constants directly.
>>
>> Also realize that all papers measured in inches can be expressed exactly in
>> points (after the above errors ar
On Sat, 23 Sep 2023 05:39:12 GMT, John Hendrikx wrote:
>> what kind of FP error could option 1 lead to?
>>
>> I think rounding belongs to the UI, to the panel which displays the sizes
>> with precision given by the requirements. So this method, I think, should
>> return the unmodified value.
On Sat, 23 Sep 2023 06:00:40 GMT, John Hendrikx wrote:
>> Some observations on the paper class:
>>
>> /**
>> * Specifies the North American legal size, 8.5 inches by 14 inches.
>> */
>> public static final Paper LEGAL = new Paper("Legal", 8.4, 14, INCH);
>>
>>
>> The comment
On Fri, 22 Sep 2023 18:33:49 GMT, Andy Goryachev wrote:
>>> > yeah, I also don't quite understand why we have the rounding (I mean,
>>> > floor'ing) here. I would vote to remove the typecast as the OP proposes.
>>>
>>> Phil has some concerns that will need to be looked into.
>>
>> To follow-on
On Fri, 22 Sep 2023 18:21:56 GMT, Kevin Rushforth wrote:
>>> yeah, I also don't quite understand why we have the rounding (I mean,
>>> floor'ing) here. I would vote to remove the typecast as the OP proposes.
>>
>> Phil has some concerns that will need to be looked into.
>>
>>> But there is mor
On Fri, 22 Sep 2023 18:07:50 GMT, Kevin Rushforth wrote:
> > yeah, I also don't quite understand why we have the rounding (I mean,
> > floor'ing) here. I would vote to remove the typecast as the OP proposes.
>
> Phil has some concerns that will need to be looked into.
To follow-on, it seems th
On Fri, 22 Sep 2023 17:34:45 GMT, Andy Goryachev wrote:
> yeah, I also don't quite understand why we have the rounding (I mean,
> floor'ing) here. I would vote to remove the typecast as the OP proposes.
Phil has some concerns that will need to be looked into.
> But there is more:
>
> 1. why i
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
The Method javafx.print.getWidth and getHeight returns a double of points.
But the values are always rounded to full integers. This causes especially
problems,
with mm based Papers.
I asked in the mailing list, with the conclusion (me and John Hendrix) that is
best to just fix this behavior by r
29 matches
Mail list logo
