Re: [jfx21u] RFR: 8314484: Update Gradle to 8.4 [v2]

2023-10-30 Thread Kevin Rushforth
On Mon, 30 Oct 2023 17:44:01 GMT, Ambarish Rapte wrote: >> Clean backport to jfx21. >> Verified a build locally on macOS. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > Empty commit All looks good. And I see a clean GHA

Re: [jfx21u] RFR: 8314484: Update Gradle to 8.4 [v2]

2023-10-30 Thread Ambarish Rapte
> Clean backport to jfx21. > Verified a build locally on macOS. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: Empty commit - Changes: - all: https://git.openjdk.org/jfx21u/pull/22/files - new: https://git.openjdk

Re: [jfx21u] RFR: 8314484: Update Gradle to 8.4

2023-10-30 Thread Kevin Rushforth
On Mon, 30 Oct 2023 15:32:34 GMT, Ambarish Rapte wrote: > Clean backport to jfx21. > Verified a build locally on macOS. @arapte Can you enable GHA for your repo and then run it? - PR Comment: https://git.openjdk.org/jfx21u/pull/22#issuecomment-1785661149

[jfx21u] RFR: 8314484: Update Gradle to 8.4

2023-10-30 Thread Ambarish Rapte
Clean backport to jfx21. Verified a build locally on macOS. - Commit messages: - 8318115: Webkit build fails after gradle 8.4 - 8314484: Update Gradle to 8.4 - 8314486: JavaFX build uses deprecated features that will be removed in gradle 8 Changes: https://git.openjdk.org/jfx21u/

Re: RFR: 8314484: Update Gradle to 8.4

2023-10-12 Thread Johan Vos
On Tue, 10 Oct 2023 17:39:53 GMT, Ambarish Rapte wrote: > Upgrade gradle to version 8.4. > It also includes a change for adding task dependency for windows platform > that was missed in [JDK-8314486](https://bugs.openjdk.org/browse/JDK-8314486) tested on Ubuntu 22.04: all good. -

Re: RFR: 8314484: Update Gradle to 8.4

2023-10-10 Thread Kevin Rushforth
On Tue, 10 Oct 2023 17:39:53 GMT, Ambarish Rapte wrote: > Upgrade gradle to version 8.4. > It also includes a change for adding task dependency for windows platform > that was missed in [JDK-8314486](https://bugs.openjdk.org/browse/JDK-8314486) Looks good. I tested on Windows and confirm that i

Re: RFR: 8314484: Update Gradle to 8.4

2023-10-10 Thread Kevin Rushforth
On Tue, 10 Oct 2023 17:39:53 GMT, Ambarish Rapte wrote: > Upgrade gradle to version 8.4. > It also includes a change for adding task dependency for windows platform > that was missed in [JDK-8314486](https://bugs.openjdk.org/browse/JDK-8314486) @johanvos or @tiainen can one of you be the second

RFR: 8314484: Update Gradle to 8.4

2023-10-10 Thread Ambarish Rapte
Upgrade gradle to version 8.4. It also includes a change for adding task dependency for windows platform that was missed in [JDK-8314486](https://bugs.openjdk.org/browse/JDK-8314486) - Commit messages: - chmod 644 gradlew - fix win task dependency - upgrade gradle to 8.4 Changes: