Re: RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-14 Thread Kevin Rushforth
On Mon, 14 Aug 2023 16:46:33 GMT, Andy Goryachev wrote: >> - Fixed by checking for `NULL` pointer after memory allocation. >> - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` >> array, so `new` will return `NULL` instead of throwing exception. This done >> for consistenc

Re: RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-14 Thread Andy Goryachev
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote: > - Fixed by checking for `NULL` pointer after memory allocation. > - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` > array, so `new` will return `NULL` instead of throwing exception. This done > for consistency

[jfx21u] RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-08 Thread Alexander Matveev
This is clean backport of JDK-8313900. - Commit messages: - Backport 9f180e20adc5bc8e6892d9672a414e8b7f614a20 Changes: https://git.openjdk.org/jfx21u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=7&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313900 S

Re: RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-08 Thread Ambarish Rapte
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote: > - Fixed by checking for `NULL` pointer after memory allocation. > - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` > array, so `new` will return `NULL` instead of throwing exception. This done > for consistency

Re: RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-08 Thread Kevin Rushforth
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote: > - Fixed by checking for `NULL` pointer after memory allocation. > - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` > array, so `new` will return `NULL` instead of throwing exception. This done > for consistency

Re: RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-08 Thread Kevin Rushforth
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote: > - Fixed by checking for `NULL` pointer after memory allocation. > - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` > array, so `new` will return `NULL` instead of throwing exception. This done > for consistency

RFR: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

2023-08-07 Thread Alexander Matveev
- Fixed by checking for `NULL` pointer after memory allocation. - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` array, so `new` will return `NULL` instead of throwing exception. This done for consistency and also it is not clear how well JNI handles C++ exceptions in thi