Re: [jfx21u] RFR: 8313856: Replace VLA with malloc in pango

2023-08-08 Thread Jayathirth D V
On Wed, 9 Aug 2023 05:13:36 GMT, Jayathirth D V wrote: > This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u. > > We should not use stack memory for large VLA allocations in pango.c @kevinrushforth and @arapte please review. - PR Comment: https://git.openjdk.

[jfx21u] RFR: 8313856: Replace VLA with malloc in pango

2023-08-08 Thread Jayathirth D V
This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u. We should not use stack memory for large VLA allocations in pango.c - Commit messages: - Backport 1752b62320f9e42f6d0d2c1f8278cf2ab205a8f4 Changes: https://git.openjdk.org/jfx21u/pull/8/files Webrev: https:

Re: RFR: 8313856: Replace VLA with malloc in pango

2023-08-07 Thread Kevin Rushforth
On Mon, 7 Aug 2023 04:55:23 GMT, Jayathirth D V wrote: > We should not use stack for array memory allocations in JNI. > Updated pango.c to use malloc for arrays and release them at appropriate > places. Looks good. One slight clarification: > We should not use stack for array memory allocatio

Re: RFR: 8313856: Replace VLA with malloc in pango

2023-08-06 Thread Ambarish Rapte
On Mon, 7 Aug 2023 04:55:23 GMT, Jayathirth D V wrote: > We should not use stack for array memory allocations in JNI. > Updated pango.c to use malloc for arrays and release them at appropriate > places. LGTM - Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjd

RFR: 8313856: Replace VLA with malloc in pango

2023-08-06 Thread Jayathirth D V
We should not use stack for array memory allocations in JNI. Updated pango.c to use malloc for arrays and release them at appropriate places. - Commit messages: - 8313856: Replace VLA with malloc in pango Changes: https://git.openjdk.org/jfx/pull/1202/files Webrev: https://webrevs.