Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Michael Strauß
On Tue, 22 Oct 2024 20:42:13 GMT, Michael Strauß wrote: >> Another aspect is whether this should be a conditional feature. >> If not, how will it be supported on Android/iOS? RaspPI? > >> Another aspect is whether this should be a conditional feature. If not, how >> will it be supported on Andr

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Tue, 22 Oct 2024 20:42:13 GMT, Michael Strauß wrote: >> Another aspect is whether this should be a conditional feature. >> If not, how will it be supported on Android/iOS? RaspPI? > >> Another aspect is whether this should be a conditional feature. If not, how >> will it be supported on Andr

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Michael Strauß
On Tue, 22 Oct 2024 17:44:08 GMT, Andy Goryachev wrote: > Continuing on window attributes. I would like to know what is and is not > supported by platform, by feature. > > For example: > > Windows > > * translucency > * color gradient > * system menu on right click, on the toolbar and on the

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Thiago Milczarek Sayao
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Michael Strauß
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Nir Lisker
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Thiago Milczarek Sayao
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-21 Thread quizy...@gmail.com
Hello, Thank you so much for your effort! I'm really glad this hasn't been forgotten. I wouldn't say it's just popular demand; it's an absolute must. Here are a few thoughts, if you don't mind. Every modern platform supports this feature: Electron, Tauri, Wails, Qt, and even Swing via FlatLaf. If

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-21 Thread Michael Strauß
On Mon, 21 Oct 2024 10:55:53 GMT, Thiago Milczarek Sayao wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert unintended change > > A few points observed on Linux: > 1) It's possible to resize it to 1px using

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-21 Thread Michael Strauß
On Mon, 21 Oct 2024 22:45:28 GMT, Andy Goryachev wrote: > To clarify about height: do all the platforms support arbitrary height? What > if size set by the app/CSS exceeds the height supported by the platform? Yes, all platforms support header bars of arbitrary height. You can make the header

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-21 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-21 Thread Michael Strauß
On Mon, 21 Oct 2024 20:59:00 GMT, Andy Goryachev wrote: > I suggest we convert this PR to Draft and first discuss this in the mailing > list. This has already been [discussed](https://mail.openjdk.org/pipermail/openjfx-dev/2021-July/031428.html) at various points in time, and was always recei

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-21 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-21 Thread Thiago Milczarek Sayao
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-20 Thread Michael Strauß
On Sun, 20 Oct 2024 12:39:37 GMT, Glavo wrote: > Hey, I'm glad to see this PR, but do you have any ideas for continuing to > provide `UNDECORATED_INTERACTIVE` in the future? I think > `UNDECORATED_INTERACTIVE` is more useful than `EXTENDED` for users who want > to provide a consistent UI on di

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-20 Thread Thiago Milczarek Sayao
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-20 Thread Glavo
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-19 Thread Michael Strauß
> This PR is a new take on a highly requested feature: JavaFX controls in the > header bar (see also #594 for an earlier iteration). > > This is a feature with many possible ways to skin the cat, and it has taken > quite a bit of effort to come up with a good user model. In contrast to the > pr