Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]

2023-10-18 Thread Joeri Sykora
On Wed, 11 Oct 2023 03:58:01 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]

2023-10-17 Thread Kevin Rushforth
On Tue, 5 Sep 2023 07:17:57 GMT, Johan Vos wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change minimum version for mac to 3.6 > > I think that should be ok for now, and I don't want to make the PR more > com

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]

2023-10-10 Thread Hima Bindu Meda
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-10-10 Thread Kevin Rushforth
On Mon, 14 Aug 2023 15:52:03 GMT, Hima Bindu Meda wrote: >> I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it >> has python 3.7.x: >> >> >> Could NOT find Python3: Found unsuitable version "3.7.3", but required is >> at least "3.8.0" (found /usr/bin/python3, found

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]

2023-09-05 Thread John Neffenger
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]

2023-09-05 Thread Johan Vos
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]

2023-08-15 Thread Kevin Rushforth
On Mon, 14 Aug 2023 16:17:29 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-14 Thread Hima Bindu Meda
On Thu, 10 Aug 2023 23:00:11 GMT, Kevin Rushforth wrote: > I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it > has python 3.7.x: > > ``` > Could NOT find Python3: Found unsuitable version "3.7.3", but required is > at least "3.8.0" (found /usr/bin/python3, found co

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]

2023-08-14 Thread Hima Bindu Meda
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-10 Thread Kevin Rushforth
On Wed, 9 Aug 2023 07:31:57 GMT, Hima Bindu Meda wrote: > Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen I tested this on my MacBook Pro running macOS

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-10 Thread Kevin Rushforth
On Wed, 9 Aug 2023 07:31:57 GMT, Hima Bindu Meda wrote: > Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Reviewers: @kevinrushforth @johanvos @tiainen

RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-09 Thread Hima Bindu Meda
Minimum version of python ,to run webkit build , on linux is set to 3.6 and for other platforms, minimum version of python is set to 3.8. Verified build on all platforms. No issue seen - Commit messages: - Add check for python version for various platforms Changes: https://git.ope