Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-06-06 Thread Andy Goryachev
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote: >> Fixed a memory leak in TreeTableView by reverting to register**Listener >> (which is ok in this particular situation) - the leak is specific to >> TreeTableRowSkin. >> >> Added a unit test. > > Andy Goryachev has updated the pull reque

Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-06-06 Thread Marius Hanl
On Tue, 6 Jun 2023 15:56:45 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java >> line 117: >> >>> 115: TreeTableView treeTableView = >>> getSkinnable().getTreeTableView(); >>> 116: if (treeTableView == null) { >>

Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-06-06 Thread Marius Hanl
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote: >> Fixed a memory leak in TreeTableView by reverting to register**Listener >> (which is ok in this particular situation) - the leak is specific to >> TreeTableRowSkin. >> >> Added a unit test. > > Andy Goryachev has updated the pull reque

Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-06-06 Thread Andy Goryachev
On Tue, 6 Jun 2023 09:36:37 GMT, Marius Hanl wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 17 additional >> commits s

Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-06-06 Thread Marius Hanl
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote: >> Fixed a memory leak in TreeTableView by reverting to register**Listener >> (which is ok in this particular situation) - the leak is specific to >> TreeTableRowSkin. >> >> Added a unit test. > > Andy Goryachev has updated the pull reque

Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-06-05 Thread Kevin Rushforth
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote: >> Fixed a memory leak in TreeTableView by reverting to register**Listener >> (which is ok in this particular situation) - the leak is specific to >> TreeTableRowSkin. >> >> Added a unit test. > > Andy Goryachev has updated the pull reque

Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-06-05 Thread Ajit Ghaisas
On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev wrote: >> Fixed a memory leak in TreeTableView by reverting to register**Listener >> (which is ok in this particular situation) - the leak is specific to >> TreeTableRowSkin. >> >> Added a unit test. > > Andy Goryachev has updated the pull reque

Re: RFR: 8307538: Memory leak in TreeTableView when calling refresh [v7]

2023-05-15 Thread Andy Goryachev
> Fixed a memory leak in TreeTableView by reverting to register**Listener > (which is ok in this particular situation) - the leak is specific to > TreeTableRowSkin. > > Added a unit test. Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The increme