Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v3]

2023-06-27 Thread Karthik P K
On Tue, 27 Jun 2023 17:56:09 GMT, Andy Goryachev wrote: > right. in the case of the (highlighted) emoji character - the insertion index > starts with 0 which I think cannot be correct, because all of the text should > be added as a single Text instance, see > If a Text node's content is wrappe

Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v3]

2023-06-27 Thread Andy Goryachev
On Tue, 27 Jun 2023 17:49:48 GMT, Karthik P K wrote: > The insertion index is reported relative to the Text's text incase of Text > node. right. in the case of the (highlighted) emoji character - the insertion index starts with 0 which I think cannot be correct, because all of the text should

Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v3]

2023-06-27 Thread Karthik P K
On Tue, 27 Jun 2023 16:13:03 GMT, Andy Goryachev wrote: > I think not only it shows incorrect insertion index when you move the mouse > across that emoji (in Text.hitTest goes from 0 to 1, while expected change is > 2), but I think it's also wrong because that emoji is the last symbol in that

Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v3]

2023-06-27 Thread Andy Goryachev
On Tue, 27 Jun 2023 16:06:18 GMT, Karthik P K wrote: >> The text run selected in `PrismTextLayout::getHitInfo()` method for >> character index calculation was not correct when Text node was embedded in >> TextFlow. Hence wrong character index value was calculated for the same. >> >> Since only

Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v3]

2023-06-27 Thread Karthik P K
> The text run selected in `PrismTextLayout::getHitInfo()` method for character > index calculation was not correct when Text node was embedded in TextFlow. > Hence wrong character index value was calculated for the same. > > Since only x, y coordinates were available in the above mentioned meth