Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Thiago Milczarek Sayao
On Sun, 15 Dec 2024 20:57:14 GMT, Martin Fox wrote: >> I modified it to no longer rely on pre-edit calls, but I'm not sure if it's >> working as expected yet. > > When fcitx is configured this way we never receive pre-editing signals AND > we're not filtering a key event when the commit comes i

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Martin Fox
On Sun, 15 Dec 2024 20:26:22 GMT, Thiago Milczarek Sayao wrote: >> This option sets if editing happens on the application or in the IME window. >> >> Application: >> ![image](https://github.com/user-attachments/assets/d44364ad-4090-4e1d-9fcf-5fa7fbd8a306) >> >> >> IME Window: >> ![image](http

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Thiago Milczarek Sayao
On Sun, 15 Dec 2024 19:09:29 GMT, Thiago Milczarek Sayao wrote: >> Anyway, current solution without checking `im_ctx.on_preedit` can work well. >> I backported it to `jfx22` and it worked well. Thanks again. And hope for >> the final solution. > > This option sets if editing happens on the app

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Thiago Milczarek Sayao
On Thu, 12 Dec 2024 23:53:55 GMT, Helly Guo wrote: >> @hellyguo Thanks so much for tracking this down and providing all the >> details. I would like to better understand what that checkbox does but I >> might not be able to get to that until next week. >> >> JavaFX handles keyboard entry using

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Thu, 12 Dec 2024 15:25:29 GMT, Martin Fox wrote: >> ![pic_20241212193112](https://github.com/user-attachments/assets/7b9233f9-3af5-42d5-89f9-9f85248d68dd) >> >> The option is surrounded by a red box. > > @hellyguo Thanks so much for tracking this down and providing all the > details. I would

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Martin Fox
On Thu, 12 Dec 2024 11:41:20 GMT, Helly Guo wrote: >> Finally, I got the point. Fcitx5 has a setting entry: `Show preedit in >> application`. If this is on, it works well. If this is off, the value >> `im_ctx.on_preedit` will get `false` when im(`fcitx5`) finished >> input-action. Then, the in

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Thu, 12 Dec 2024 10:15:19 GMT, Helly Guo wrote: >> @hellyguo I can't reproduce the problem you're seeing. I configured a Debian >> Bookworm system with Fcitx5 and Pinyin and tested this PR and everything >> worked. The Linux and Fcitx version numbers are the same as yours. I also >> install

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Thu, 12 Dec 2024 11:38:37 GMT, Helly Guo wrote: >> @beldenfox , you are right. >> I created a brand new env in virt-manager: >> >> >> virt@virtdeb:~$ uname -a >> Linux virtdeb 6.1.0-28-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.119-1 >> (2024-11-22) x86_64 GNU/Linux >> >> virt@virtdeb:~$ cat

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-12 Thread Helly Guo
On Wed, 11 Dec 2024 16:46:02 GMT, Martin Fox wrote: >> hi @beldenfox / @tsayao , thanks for response. >> >> here is my env. >> >> >> # uname -a >> Linux workdeb 6.1.0-28-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.119-1 >> (2024-11-22) x86_64 GNU/Linux >> >> # cat /etc/os-release >> PRETTY_NAME=

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-11 Thread Martin Fox
On Tue, 10 Dec 2024 09:52:38 GMT, Helly Guo wrote: >> @hellyguo Could you provide more details on which Linux distribution, input >> method, and fcitx version you're using? >> >> I just tested this on Ubuntu 24.10. For Chinese I'm using Intelligent Pinyin >> and for Japanese I'm using Mozc. Ev

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-10 Thread Helly Guo
On Mon, 9 Dec 2024 17:25:58 GMT, Martin Fox wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line >> 100: >> >>> 98: >>> 99: void WindowContextBase::commitIME(gchar *str) { >>> 100: if (im_ctx.on_preedit) { >> >> Through `LOG0`/`LOG1`, I found that the valu

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-09 Thread Thiago Milczarek Sayao
On Mon, 9 Dec 2024 17:25:58 GMT, Martin Fox wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line >> 100: >> >>> 98: >>> 99: void WindowContextBase::commitIME(gchar *str) { >>> 100: if (im_ctx.on_preedit) { >> >> Through `LOG0`/`LOG1`, I found that the valu

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-09 Thread Martin Fox
On Thu, 5 Dec 2024 07:12:20 GMT, Helly Guo wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 114 commits: >> >> - Merge branch 'master' into new_ime >> - Set IBUS_ENABLE_SYNC_MODE=1 >> - Revert "S

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-04 Thread Helly Guo
On Wed, 4 Dec 2024 20:11:08 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-04 Thread Thiago Milczarek Sayao
> This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. > > [Screencast from 17-09-2023 > 21:59:04.webm](https://github.com/openj