Re: RFR: 8299423: JavaFX Mac system menubar leaks

On Wed, 13 Mar 2024 13:32:32 GMT, Florian Kirmaier wrote: > Because it was fixed in some other PR. Which other PR fixed this? The JBS bug should be linked to that bug, and possibly reference it in the title. Speaking of which, the current title is not accurate and should be changed to reflec

Re: RFR: 8299423: JavaFX Mac system menubar leaks

On Wed, 13 Mar 2024 13:32:32 GMT, Florian Kirmaier wrote: > Based on my previous PR: https://github.com/openjdk/jfx/pull/987 > This one only contains the test. > Because it was fixed in some other PR. > But i would like to see the Test being merged, to ensure it never breaks > again. Changes r

RFR: 8299423: JavaFX Mac system menubar leaks

Based on my previous PR: https://github.com/openjdk/jfx/pull/987 This one only contains the test. Because it was fixed in some other PR. But i would like to see the Test being merged, to ensure it never breaks again. - Commit messages: - Added test for JDK-8299423 Changes: https://g

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

On Fri, 13 Jan 2023 09:18:56 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called f

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

> On Jan 16, 2023, at 10:33 PM, Scott Palmer wrote: > > There are third-party libraries for better integration with the Mac menu bar. > > E.g. https://github.com/codecentric/NSMenuFX > > > Though I wish this wasn’t necessary and proper hooks were pre

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

Not directly related but I recently was looking at the Mac system menubar for javaFX applications noticing that they do not get an ‘About’ menu item in the Application menu. I filed a bug that was just accepted today. JDK-8300180 : [macos] Default About menu item not shown for javaFX applicatio

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

On Fri, 13 Jan 2023 09:18:56 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called f

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v4]

On Wed, 11 Jan 2023 19:31:14 GMT, Michael Strauß wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8299423 >> Added null check before using the callback > > tests/system/src/test/java/test/javafx/scene/cont

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

On Fri, 13 Jan 2023 09:18:56 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called f

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

> This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for the MenuEntry, if it's removed from > the menu without removing

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v4]

On Wed, 11 Jan 2023 09:22:07 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called f

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v3]

On Thu, 5 Jan 2023 16:15:38 GMT, Michael Strauß wrote: >> I've tested this version with explicit GC, and it still worked. So i guess >> it's stable. >> >> Ok, so now there are multiple Solutions: >> >> 1. Revert to the previous version, and remove the WeakReference again. >> 2. Add an explicit

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v4]

> This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for the MenuEntry, if it's removed from > the menu without removing

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v3]

On Thu, 5 Jan 2023 09:03:56 GMT, Florian Kirmaier wrote: > I've tested this version with explicit GC, and it still worked. So i guess > it's stable. > > Ok, so now there are multiple Solutions: > > 1. Revert to the previous version, and remove the WeakReference again. > 2. Add an explicit refe

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v3]

On Thu, 5 Jan 2023 08:34:14 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called for

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v3]

> This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for the MenuEntry, if it's removed from > the menu without removing

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v2]

On Mon, 2 Jan 2023 09:26:14 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called for

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v2]

On Mon, 2 Jan 2023 09:26:14 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called for

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v2]

> This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for the MenuEntry, if it's removed from > the menu without removing

Re: RFR: 8299423: JavaFX Mac system menubar leaks

On Sat, 31 Dec 2022 04:18:09 GMT, Michael Strauß wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called for

Re: RFR: 8299423: JavaFX Mac system menubar leaks

On Fri, 30 Dec 2022 09:41:46 GMT, Florian Kirmaier wrote: > This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for the

RFR: 8299423: JavaFX Mac system menubar leaks

This PR fixes the leak in the mac system menu bar. Inside the native code, NewGlobalRef is called for the callable. Which makes it into a "GC-Root" until DeleteGlobalRef is called. The DeleteGlobalRef is never called for the MenuEntry, if it's removed from the menu without removing it's callable