Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v3]

2024-08-13 Thread Marius Hanl
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote: >> 1. Added logic to look in the standard locations for Visual Studio 2022, >> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in >> the following locations: >> >> C:("Program Files"|"Program Files (x86)")\Micros

Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v3]

2024-08-13 Thread Nir Lisker
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote: >> 1. Added logic to look in the standard locations for Visual Studio 2022, >> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in >> the following locations: >> >> C:("Program Files"|"Program Files (x86)")\Micros

Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v3]

2024-08-12 Thread Phil Race
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote: >> 1. Added logic to look in the standard locations for Visual Studio 2022, >> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in >> the following locations: >> >> C:("Program Files"|"Program Files (x86)")\Micros

Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v3]

2024-08-12 Thread Kevin Rushforth
On Mon, 12 Aug 2024 20:41:13 GMT, Phil Race wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments > > buildSrc/win.gradle line 93: > >> 91: defineProperty("WINDOWS_VS_LIB", properties, >> "$W

Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v3]

2024-08-12 Thread Kevin Rushforth
> 1. Added logic to look in the standard locations for Visual Studio 2022, with > a fallback to 2019 and then 2017 if 2022 is not found. It will look in the > following locations: > > C:("Program Files"|"Program Files (x86)")\Microsoft Visual > Studio(2022|2019|2017)\ > (Enterprise|Profess