On Fri, 22 Nov 2024 22:14:12 GMT, Martin Fox wrote:
>> I'll take a look at it after Thanksgiving.
>>
>> Somewhat related questions (sorry if totally unrelated):
>>
>> Q1. shouldn't the input method be tied to the `Scene.focusOwner` property
>> somehow?
>> Q2. given the fact that there could be
On Fri, 13 Dec 2024 16:26:54 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
On Fri, 13 Dec 2024 16:26:54 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
> Input methods don’t work for text controls inside Popups. This PR fixes that.
>
> Some background:
>
> A PopupWindow always has an owner. The owner of the first Popup is a standard
> Window; I’ll refer to that as the root window. But a popup can show another
> popup (for example, a popup may
On Tue, 12 Nov 2024 15:08:11 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
On Wed, 4 Dec 2024 14:39:55 GMT, Martin Fox wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/InputMethodStateManager.java
>> line 48:
>>
>>> 46: * PopupWindow.
>>> 47: */
>>> 48: public class InputMethodStateManager {
>>
>> All this feels overly complicated -
>>
>> Why d
On Wed, 4 Dec 2024 18:14:58 GMT, Kevin Rushforth wrote:
>> One can extend `PopupWindow` and call the protected `setScene()`, so this is
>> a valid scenario, I think.
>
> PopupWindow already specifies that subclasses should not do this:
>
>
> Note to subclasses: the scene used by PopupWindow is
On Wed, 4 Dec 2024 15:36:00 GMT, Andy Goryachev wrote:
>> In a PopupWindow the scene there is no API to set the scene. It's managed
>> internally by the system and should not change over the lifetime of the
>> popup window. I will take a second look at that code next week to verify.
>
> One can
On Wed, 4 Dec 2024 14:39:52 GMT, Martin Fox wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/PopupWindow.java line 578:
>>
>>> 576: // still monitoring owner events.
>>> 577: Scene scene = getScene();
>>> 578:
>>> SceneHelper.getInputMethodStateMa
On Tue, 3 Dec 2024 22:06:48 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak to satisfy system test.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/InputMethodStateManager.jav
On Tue, 12 Nov 2024 15:08:11 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
On Tue, 12 Nov 2024 15:08:11 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
On Fri, 22 Nov 2024 19:51:18 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak to satisfy system test.
>
> I'll take a look at it after Thanksgiving.
>
> Somewhat related questions (sorry if
On Tue, 12 Nov 2024 15:08:11 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
> Input methods don’t work for text controls inside Popups. This PR fixes that.
>
> Some background:
>
> A PopupWindow always has an owner. The owner of the first Popup is a standard
> Window; I’ll refer to that as the root window. But a popup can show another
> popup (for example, a popup may
On Mon, 11 Nov 2024 19:34:04 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
> Input methods don’t work for text controls inside Popups. This PR fixes that.
>
> Some background:
>
> A PopupWindow always has an owner. The owner of the first Popup is a standard
> Window; I’ll refer to that as the root window. But a popup can show another
> popup (for example, a popup may
Input methods don’t work for text controls inside Popups. This PR fixes that.
Some background:
A PopupWindow always has an owner. The owner of the first Popup is a standard
Window; I’ll refer to that as the root window. But a popup can show another
popup (for example, a popup may contain a Comb
18 matches
Mail list logo
