Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v3]

2023-12-05 Thread Ajit Ghaisas
On Wed, 22 Nov 2023 17:05:36 GMT, Ambarish Rapte wrote: >> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y >> client application requests for it. >> Ideally we should use the text set by `Node.setAccessibleText()` as the >> `UIA_NamePropertyId`. >> For other control

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v3]

2023-12-03 Thread Ambarish Rapte
On Fri, 1 Dec 2023 23:34:12 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Mac a11y change for VALUE_STRING attribute for Spinner > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/m

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v3]

2023-12-01 Thread Kevin Rushforth
On Wed, 22 Nov 2023 17:05:36 GMT, Ambarish Rapte wrote: >> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y >> client application requests for it. >> Ideally we should use the text set by `Node.setAccessibleText()` as the >> `UIA_NamePropertyId`. >> For other control

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v3]

2023-11-22 Thread Ambarish Rapte
On Wed, 22 Nov 2023 17:05:36 GMT, Ambarish Rapte wrote: >> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y >> client application requests for it. >> Ideally we should use the text set by `Node.setAccessibleText()` as the >> `UIA_NamePropertyId`. >> For other control

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v3]

2023-11-22 Thread Ambarish Rapte
> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y > client application requests for it. > Ideally we should use the text set by `Node.setAccessibleText()` as the > `UIA_NamePropertyId`. > For other controls such as Slider, ListView we use the text set by > setAccessi

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v2]

2023-11-21 Thread Ambarish Rapte
On Tue, 21 Nov 2023 16:32:26 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add @since 22 > > modules/javafx.controls/src/main/java/javafx/scene/control/Spinner.java line > 851: > >> 849:

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed [v2]

2023-11-21 Thread Ambarish Rapte
> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y > client application requests for it. > Ideally we should use the text set by `Node.setAccessibleText()` as the > `UIA_NamePropertyId`. > For other controls such as Slider, ListView we use the text set by > setAccessi

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed

2023-11-21 Thread Kevin Rushforth
On Mon, 20 Nov 2023 05:37:38 GMT, Ambarish Rapte wrote: > Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y > client application requests for it. > Ideally we should use the text set by `Node.setAccessibleText()` as the > `UIA_NamePropertyId`. > For other controls suc

Re: RFR: 8284544: [Win] Name-Property of Spinner cannot be changed

2023-11-20 Thread Kevin Rushforth
On Mon, 20 Nov 2023 05:37:38 GMT, Ambarish Rapte wrote: > Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y > client application requests for it. > Ideally we should use the text set by `Node.setAccessibleText()` as the > `UIA_NamePropertyId`. > For other controls suc

RFR: 8284544: [Win] Name-Property of Spinner cannot be changed

2023-11-19 Thread Ambarish Rapte
Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y client application requests for it. Ideally we should use the text set by `Node.setAccessibleText()` as the `UIA_NamePropertyId`. For other controls such as Slider, ListView we use the text set by setAccessibleText() AP