Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v46]

2023-03-11 Thread Kevin Rushforth
On Thu, 2 Feb 2023 12:58:31 GMT, Johan Vos wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Fix JDK-8089923 >> - Fix JDK-8089923 >> - Fix JDK-8089923 >> - Fix deiconify regression > > I'll re-review

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v46]

2023-02-12 Thread Thiago Milczarek Sayao
On Mon, 23 Jan 2023 03:51:33 GMT, Thiago Milczarek Sayao wrote: >> This cleans size and positioning code, reducing special cases, code >> complexity and size. >> >> Changes: >> >> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different >> sizes. It does not assume any si

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v46]

2023-02-09 Thread Kevin Rushforth
On Mon, 23 Jan 2023 03:51:33 GMT, Thiago Milczarek Sayao wrote: >> This cleans size and positioning code, reducing special cases, code >> complexity and size. >> >> Changes: >> >> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different >> sizes. It does not assume any si

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v46]

2023-02-02 Thread Johan Vos
On Mon, 23 Jan 2023 03:51:33 GMT, Thiago Milczarek Sayao wrote: >> This cleans size and positioning code, reducing special cases, code >> complexity and size. >> >> Changes: >> >> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different >> sizes. It does not assume any si

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v46]

2023-01-23 Thread Thiago Milczarek Sayao
On Mon, 23 Jan 2023 03:51:33 GMT, Thiago Milczarek Sayao wrote: >> This cleans size and positioning code, reducing special cases, code >> complexity and size. >> >> Changes: >> >> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different >> sizes. It does not assume any si

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v46]

2023-01-22 Thread Thiago Milczarek Sayao
> This cleans size and positioning code, reducing special cases, code > complexity and size. > > Changes: > > - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different > sizes. It does not assume any size because it varies - it does cache because > it's unlikely to vary on t