On Fri, 10 Feb 2023 09:57:21 GMT, Ajit Ghaisas wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimizing computePrefWidth method
>
> Looks good!
@aghaisas please sponsor this PR.
-
PR: https://git.op
On Thu, 9 Feb 2023 14:40:15 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Thu, 9 Feb 2023 14:40:15 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Thu, 9 Feb 2023 14:40:15 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Mon, 6 Feb 2023 14:23:38 GMT, Karthik P K wrote:
>> Both `computePrefHeight()` and `computePrefWidth` can be restructured to
>> avoid unnecessary computation (especially since these are very popular
>> objects).
>>
>> My point is that, for example, textWidth on line 375 (used to compute
>>
On Thu, 9 Feb 2023 14:40:15 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Wed, 8 Feb 2023 19:57:46 GMT, Andy Goryachev wrote:
>> Previously both `textWidth` and `graphicWidth` were calculated regardless of
>> the condition. In the updated code calculation of `graphicWidth` is moved to
>> `else` block so that one unnecessary calculation is avoided. Since
>> `textW
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were
>
On Wed, 8 Feb 2023 20:03:05 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> For your convenience, I've added a Label page to the monkey tester
> https://github.com/
On Wed, 8 Feb 2023 12:46:15 GMT, Karthik P K wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
>> line 328:
>>
>>> 326: }
>>> 327:
>>> 328: double textWidth = emptyText ? 0.0 :
>>> Utils.computeTextWidth(font, cleanText, 0);
>>
>>
On Wed, 8 Feb 2023 12:19:34 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Tue, 7 Feb 2023 20:06:27 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
>
On Tue, 7 Feb 2023 19:57:00 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
>
On Tue, 7 Feb 2023 19:47:50 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
>
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were
>
On Tue, 7 Feb 2023 05:25:08 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Tue, 7 Feb 2023 05:25:08 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Tue, 7 Feb 2023 05:25:08 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Mon, 6 Feb 2023 22:50:30 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code optimization
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
> line 331:
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were
>
On Mon, 6 Feb 2023 13:33:20 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present fo
On Fri, 3 Feb 2023 18:04:09 GMT, Andy Goryachev wrote:
>> Not sure if I didn't understand your comments properly but I'm guessing you
>> are referring to `textHeight` and `graphicHeight` calculation in line 375
>> and 380 because the line numbers you mentioned are in `computePrefWidth`
>> meth
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were
>
On Fri, 3 Feb 2023 05:56:32 GMT, Karthik P K wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
>> line 402:
>>
>>> 400: }
>>> 401:
>>> 402: return height + padding;
>>
>> My only comment is possibly reorganize the logic to avoid un
On Thu, 2 Feb 2023 16:54:28 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use width while calling prefHeight method. Use graphicHeight instead of
>> multiple calls to prefHeight
>
> modules/ja
On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present f
On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present f
On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present f
On Tue, 17 Jan 2023 11:40:47 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use width while calling prefHeight method. Use graphicHeight instead of
>> multiple calls to prefHeight
>
> modules/ja
On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present f
On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present f
On Tue, 17 Jan 2023 11:40:47 GMT, John Hendrikx wrote:
> The logic of this code seems to have changed more than just the fixing bug.
> Why are the `prefHeight` functions now called with `-1`? Normally these
> should respect the content bias of the node involved.
>
I used `-1` while calling `p
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were
>
On Mon, 16 Jan 2023 10:46:12 GMT, Karthik P K wrote:
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all
Ignore text condition was not considered in `computePrefHeight` method while
calculating the Label height.
Added `isIgnoreText` condition in `computePrefHeight` method while calculating
Label height.
Tests are present for all the ContentDisplay types. Modified tests which were
failing because
35 matches
Mail list logo
