Re: [jfx21u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-22 Thread Johan Vos
On Tue, 20 Feb 2024 10:18:36 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [90cbc663](https://github.com/openjdk/jfx/commit/90cbc66305d0a1380cf3a8cd99ad40db240e554c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

[jfx21u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-20 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [90cbc663](https://github.com/openjdk/jfx/commit/90cbc66305d0a1380cf3a8cd99ad40db240e554c) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Kevin Rushforth on 15 Jan 2024 and

Re: [jfx17u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-16 Thread Johan Vos
On Thu, 8 Feb 2024 09:11:13 GMT, Johannes Bechberger wrote: > Clean backport of 8221261: Deadlock on macOS in JFXPanel app when handling > IME calls Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx17u/pull/178#pullrequestreview-1885952738

Re: [jfx17u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-16 Thread Kevin Rushforth
On Thu, 8 Feb 2024 09:11:13 GMT, Johannes Bechberger wrote: > Clean backport of 8221261: Deadlock on macOS in JFXPanel app when handling > IME calls The backport looks fine to me. @johanvos will need to review / approve it for inclusion into jfx17u as he maintains this code line. --

Re: [jfx17u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-15 Thread Johannes Bechberger
On Thu, 8 Feb 2024 09:11:13 GMT, Johannes Bechberger wrote: > Clean backport of 8221261: Deadlock on macOS in JFXPanel app when handling > IME calls @kevinrushforth could you review it? - PR Comment: https://git.openjdk.org/jfx17u/pull/178#issuecomment-1946017234

[jfx17u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-08 Thread Johannes Bechberger
Clean backport of 8221261: Deadlock on macOS in JFXPanel app when handling IME calls - Commit messages: - 8221261: Deadlock on macOS in JFXPanel app when handling IME calls Changes: https://git.openjdk.org/jfx17u/pull/178/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=1

Re: [jfx22] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-01-15 Thread Prasanta Sadhukhan
On Mon, 15 Jan 2024 16:11:08 GMT, Kevin Rushforth wrote: > Clean backport of a safe fix for this critical deadlock bug to the jfx22 > stabilization branch during RDP1. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/1334#pullrequestreview

Re: [jfx22] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-01-15 Thread Kevin Rushforth
On Mon, 15 Jan 2024 16:11:08 GMT, Kevin Rushforth wrote: > Clean backport of a safe fix for this critical deadlock bug to the jfx22 > stabilization branch during RDP1. Reviewer: @prrace or @prsadhuk - PR Comment: https://git.openjdk.org/jfx/pull/1334#issuecomment-1892451896

[jfx22] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-01-15 Thread Kevin Rushforth
Clean backport of a safe fix for this critical deadlock bug to the jfx22 stabilization branch during RDP1. - Commit messages: - Backport 90cbc66305d0a1380cf3a8cd99ad40db240e554c Changes: https://git.openjdk.org/jfx/pull/1334/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1

Re: RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls [v2]

2024-01-13 Thread Sergey Bylokhov
On Thu, 11 Jan 2024 23:54:13 GMT, Kevin Rushforth wrote: >> As described in the JBS bug, there is a long-standing deadlock that happens >> on macOS between the AWT EDT and the JavaFX Application thread (which on >> macOS is the AppKit thread) when processing Input Method Events (IME) in a >> W

Re: RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls [v2]

2024-01-11 Thread Prasanta Sadhukhan
On Thu, 11 Jan 2024 23:54:13 GMT, Kevin Rushforth wrote: >> As described in the JBS bug, there is a long-standing deadlock that happens >> on macOS between the AWT EDT and the JavaFX Application thread (which on >> macOS is the AppKit thread) when processing Input Method Events (IME) in a >> W

Re: RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls [v2]

2024-01-11 Thread Phil Race
On Thu, 11 Jan 2024 23:54:13 GMT, Kevin Rushforth wrote: >> As described in the JBS bug, there is a long-standing deadlock that happens >> on macOS between the AWT EDT and the JavaFX Application thread (which on >> macOS is the AppKit thread) when processing Input Method Events (IME) in a >> W

Re: RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls [v2]

2024-01-11 Thread Kevin Rushforth
> As described in the JBS bug, there is a long-standing deadlock that happens > on macOS between the AWT EDT and the JavaFX Application thread (which on > macOS is the AppKit thread) when processing Input Method Events (IME) in a > WebView node in a JFXPanel. > > This PR fixes the deadlock by a

Re: RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-01-10 Thread Kevin Rushforth
On Wed, 10 Jan 2024 14:54:47 GMT, Kevin Rushforth wrote: > As described in the JBS bug, there is a long-standing deadlock that happens > on macOS between the AWT EDT and the JavaFX Application thread (which on > macOS is the AppKit thread) when processing Input Method Events (IME) in a > WebVi

RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-01-10 Thread Kevin Rushforth
As described in the JBS bug, there is a long-standing deadlock that happens on macOS between the AWT EDT and the JavaFX Application thread (which on macOS is the AppKit thread) when processing Input Method Events (IME) in a WebView node in a JFXPanel. This PR fixes the deadlock by adding `"AWTR

Re: RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-01-10 Thread Kevin Rushforth
On Wed, 10 Jan 2024 14:54:47 GMT, Kevin Rushforth wrote: > As described in the JBS bug, there is a long-standing deadlock that happens > on macOS between the AWT EDT and the JavaFX Application thread (which on > macOS is the AppKit thread) when processing Input Method Events (IME) in a > WebVi