Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-04 Thread Nir Lisker
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-04 Thread Kevin Rushforth
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-03 Thread Andy Goryachev
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-03 Thread John Hendrikx
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-03 Thread Nir Lisker
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at once. If it does, only one checkbox (its skin) can actua

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Nir Lisker
On Tue, 3 Jan 2023 23:39:36 GMT, Andy Goryachev wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added copyright header and changed package name > > tests/performance/checkboxTreeView/src/main/java/main/CheckBoxTreeEd

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Kevin Rushforth
On Tue, 3 Jan 2023 23:38:10 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread John Hendrikx
On Tue, 3 Jan 2023 23:34:06 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Andy Goryachev
On Tue, 3 Jan 2023 23:38:10 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Nir Lisker
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at once. If it does, only one checkbox (its skin) can actua

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Kevin Rushforth
On Tue, 3 Jan 2023 23:19:16 GMT, Andy Goryachev wrote: >> I wasn't sure exactly where to put it, but it's going to be used in a fix >> for a performance issue I found when a node has many children. >> >> If it will fit into a larger app, I don't mind. > > I'll move it there as a part of JDK-829

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Kevin Rushforth
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at onc

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Andy Goryachev
On Tue, 3 Jan 2023 23:13:52 GMT, Nir Lisker wrote: >> tests/performance/checkboxTreeView/.classpath line 1: >> >>> 1: >> >> minor: should this project be moved to manual tests hierarchy? >> >> BTW, I am planning to create a monkey tester application which will include >> many tests, to simpl

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Nir Lisker
On Tue, 3 Jan 2023 23:11:08 GMT, John Hendrikx wrote: > Looks good to me, releasing the graphic for empty cells. I'm left wondering > if it should also be releasing the bindings it makes in that case, although > that's less likely to cause (visible) issues. I could make that change. I don't se

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Andy Goryachev
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at onc

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Nir Lisker
On Tue, 3 Jan 2023 23:07:19 GMT, Andy Goryachev wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbo

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread John Hendrikx
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at onc

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Andy Goryachev
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at onc

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Nir Lisker
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at onc

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-01 Thread Nir Lisker
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one > checkbox at onc

RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-01 Thread Nir Lisker
A simple fix for the graphics of a `CheckBoxTreeCell` not showing after expand/collapse events. The graphics node needs to be released from the previous checkbox so that it doesn't serve as the graphics of more than one checkbox at once. If it does, only one checkbox (its skin) can actually use