Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

2023-10-20 Thread Andy Goryachev
On Fri, 20 Oct 2023 03:26:51 GMT, Sai Pradeep Dandem wrote: >> modules/javafx.graphics/src/test/java/test/javafx/scene/Node_lookup_Test.java >> line 202: >> >>> 200: */ >>> 201: @Test >>> 202: public void lookupPseudoTest3() { >> >> Consider naming the test methods according to wh

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

2023-10-19 Thread Sai Pradeep Dandem
On Fri, 20 Oct 2023 02:50:28 GMT, Michael Strauß wrote: >> Sai Pradeep Dandem has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8185831: Minor change to remove extra line >> - 8185831: Added testcase to verify when the selector ignores

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

2023-10-19 Thread Michael Strauß
On Fri, 20 Oct 2023 00:26:08 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

2023-10-19 Thread Andy Goryachev
On Fri, 20 Oct 2023 00:22:27 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

2023-10-19 Thread Sai Pradeep Dandem
> **Issue:** > Using pseudo classes in programmatic query using Node.lookupAll() or > Node.lookup() gives unexpected results. > > **Cause:** > There is no check for checking the psuedo states matching in the applies() > method of SimpleSelector.java. So checking for "applies()" alone is not > s