On Thu, 23 Mar 2023 10:32:52 GMT, Ajit Ghaisas wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update comment
>
> Looks good to me!
@aghaisas could you please sponsor this PR?
-
PR Comment: https://gi
On Fri, 17 Mar 2023 06:12:07 GMT, Karthik P K wrote:
>> Issue was observed because even when graphic height was less than text
>> height of the Label, graphic height was considered while calculating the
>> baseline offset. This was shifting the baseline offset and resulted in
>> misalignment.
On Fri, 17 Mar 2023 06:12:07 GMT, Karthik P K wrote:
>> Issue was observed because even when graphic height was less than text
>> height of the Label, graphic height was considered while calculating the
>> baseline offset. This was shifting the baseline offset and resulted in
>> misalignment.
> Issue was observed because even when graphic height was less than text height
> of the Label, graphic height was considered while calculating the baseline
> offset. This was shifting the baseline offset and resulted in misalignment.
>
> Updated `computeBaselineOffset` to exclude graphic height
On Thu, 16 Mar 2023 06:32:30 GMT, Karthik P K wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java
>> line 2136:
>>
>>> 2134: *
>>> *
>>> 2135:
>>> *
On Thu, 16 Mar 2023 12:32:36 GMT, Karthik P K wrote:
>> Please don't change all of the other comment blocks as part of this PR. You
>> can file a follow-up bug if you like, but in that case, we should first
>> define a "best practice", probably something that would align with what the
>> JDK's
On Thu, 16 Mar 2023 12:14:39 GMT, Kevin Rushforth wrote:
>> Yes javadoc comment would look better. I used the comment block to keep it
>> consistent with the other comments present in the same file. I think if
>> changing, then better to change all the comment blocks in the file.
>> Please let
On Thu, 16 Mar 2023 06:31:04 GMT, Karthik P K wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java
>> line 2102:
>>
>>> 2100:
>>> /
>>> 2101:
>>> 2102: //Test for JDK-8172
On Wed, 15 Mar 2023 18:18:45 GMT, Andy Goryachev wrote:
>> Issue was observed because even when graphic height was less than text
>> height of the Label, graphic height was considered while calculating the
>> baseline offset. This was shifting the baseline offset and resulted in
>> misalignmen
On Wed, 15 Mar 2023 10:58:14 GMT, Karthik P K wrote:
> Issue was observed because even when graphic height was less than text height
> of the Label, graphic height was considered while calculating the baseline
> offset. This was shifting the baseline offset and resulted in misalignment.
>
> Up
Issue was observed because even when graphic height was less than text height
of the Label, graphic height was considered while calculating the baseline
offset. This was shifting the baseline offset and resulted in misalignment.
Updated `computeBaselineOffset` to exclude graphic height from base
11 matches
Mail list logo
