On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Thu, 25 May 2023 16:49:10 GMT, Kevin Rushforth wrote:
> This looks good. If you haven't already done so, can you change `@link` to
> `@code` in the CSR to match? I'll review that next.
done. Thanks for the reminder!
-
PR Comment: https://git.openjdk.org/jfx/pull/1135#issuecomme
On Thu, 25 May 2023 13:06:00 GMT, Nir Lisker wrote:
> Do you think that the "Size all columns to fit" option should be added here?
Added where? In his example custom menu? Maybe, but it isn't directly relevant
to the PR. Or did you mean something else?
-
PR Comment: https://git.op
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 24 May 2023 20:09:37 GMT, Nir Lisker wrote:
> For comparison, this is the Win 10 menu:
This one is the 'extended' menu (which funny enough looks like my example
above) (it's in german):
--
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 24 May 2023 12:11:33 GMT, Kevin Rushforth wrote:
> Do you have an example application that overrides this new method? That would
> help ensure that this new API is sufficient to allow an app to create a
> custom menu. The main reason I ask is that the default implementation uses
> inte
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridden, the known default column 'ContextMenu' is
> created
On Wed, 24 May 2023 16:49:54 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 24 May 2023 13:23:46 GMT, Nir Lisker wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8091153: Added period to @implNote
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.
On Wed, 17 May 2023 19:29:13 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 17 May 2023 19:29:13 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 17 May 2023 19:35:41 GMT, Andy Goryachev wrote:
> I wish the default implementation did not hide the popup on mouse click, to
> allow for toggling multiple columns, but it is out of scope for this PR.
I agree that this behavior is rather uncomfortable.
The problem is that we are changin
On Wed, 17 May 2023 19:29:13 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 17 May 2023 13:09:09 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8091153: Improve javadoc to match the CSR
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/Tab
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridden, the known default column 'ContextMenu' is
> created
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridden, the known default column 'ContextMenu' is
> created
On Mon, 15 May 2023 22:39:52 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridden, the known default column 'ContextMenu' is
> created
On Sat, 13 May 2023 19:11:26 GMT, Marius Hanl wrote:
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridde
On Sat, 13 May 2023 19:11:26 GMT, Marius Hanl wrote:
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridde
This PR implements a way to override the table column menu.
When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
method. This new method is protected and therefore can be overidden by
developers. If not overridden, the known default column 'ContextMenu' is
created and shown
23 matches
Mail list logo
