Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-31 Thread Andy Goryachev
Cc: Kevin Rushforth , openjfx-dev Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap Andy, I should have been clearer on why I wrote this up. I think once you’ve identified the minimum API surface that’s probably all you should implement. More important to me is whether

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-31 Thread Martin Fox
; From: Martin Fox > Date: Monday, October 30, 2023 at 17:24 > To: Andy Goryachev > Cc: Kevin Rushforth , openjfx-dev > > Subject: [External] : Re: [Request for Comments] Behavior / InputMap > > I was looking over the InputMap proposal with an eye toward paring it down

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-31 Thread Andy Goryachev
Kevin Rushforth , openjfx-dev Subject: [External] : Re: [Request for Comments] Behavior / InputMap I was looking over the InputMap proposal with an eye toward paring it down to the bare minimum. >From the perspective of a user who wants to manipulate a control without >subclassing it I thi

Re: [Request for Comments] Behavior / InputMap

2023-10-30 Thread Martin Fox
dated using a number of non-trivial controls > and some new controls (RichTextArea > https://github.com/andy-goryachev-oracle/jfx/pull/1 ), I am not against > modifying/enhancing it based on the community feedback. I hope we can get to > a good solution in a reasonable time frame,

Re: [Request for Comments] Behavior / InputMap

2023-10-30 Thread Andy Goryachev
community feedback. I hope we can get to a good solution in a reasonable time frame, or we all would have to learn react and program in javascript. Cheers, -andy From: openjfx-dev on behalf of Kevin Rushforth Date: Friday, October 27, 2023 at 16:34 To: openjfx-dev Subject: Re: [Request fo

Re: [Request for Comments] Behavior / InputMap

2023-10-27 Thread Kevin Rushforth
I've mostly caught up on the (lively) discussion surrounding this feature request. It is clear that we do not yet have general agreement on the direction this proposal should take, so let's continue to discuss the proposal, its shortcomings, and any alternative approaches. We should start by

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-19 Thread Martin Fox
pment work and contribution from the > community (ghm, #1014 :-) > > To summarize, what exactly is wrong with the proposal, and why? Please be > specific. > > Thank you! > -andy > > > > From: openjfx-dev <mailto:openjfx-dev-r...@openjdk.org>> on behalf

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-18 Thread Andy Goryachev
From: openjfx-dev on behalf of Michael Strauß Date: Tuesday, October 17, 2023 at 15:56 To: Cc: openjfx-dev@openjdk.org Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap Hi Andy, I mean this in the most respectful way possible, but my feeling is that most of the argume

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-17 Thread Andy Goryachev
Goryachev , openjfx-dev@openjdk.org Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap Hi Andy, On 17/10/2023 20:07, Andy Goryachev wrote: Dear John: It looks like we have different views on the subject, so perhaps we should invite other people to weigh in. I would be

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-17 Thread Michael Strauß
Hi Andy, I mean this in the most respectful way possible, but my feeling is that most of the arguments presented in favor of this enhancement seem to be driven by an existing implementation, and not a "first-principles" analysis. I've seen many proposals on this mailing list shot down with exactl

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-17 Thread John Hendrikx
Hi Andy, On 17/10/2023 20:07, Andy Goryachev wrote: Dear John: It looks like we have different views on the subject, so perhaps we should invite other people to weigh in. I would be interested to hear from others on this subject as well. I feel however that I may need to make a more forma

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-17 Thread Andy Goryachev
Thank you! We probably should extract the skinning discussion into a separate thread. -andy From: Pedro Duque Vieira Date: Tuesday, October 17, 2023 at 05:57 To: Andy Goryachev Cc: openjfx-dev@openjdk.org Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap Yes Input

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-17 Thread Pedro Duque Vieira
inly not a call to a major > redesign. > > > > Cheers, > > -andy > > > > *From: *Pedro Duque Vieira > *Date: *Sunday, October 15, 2023 at 05:11 > *To: *Andy Goryachev > *Cc: *openjfx-dev@openjdk.org > *Subject: *[External] : Re: [Request for Comments

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-17 Thread John Hendrikx
you -andy *From: *Martin Fox *Date: *Saturday, October 14, 2023 at 14:48 *To: *John Hendrikx *Cc: *Andy Goryachev , openjfx-dev@openjdk.org *Subject: *Re: [External] : Re: [Request for Comments] Behavior / InputMap I’ve been digging around in the code to get some context on the existing mach

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Andy Goryachev
From: Martin Fox Date: Monday, October 16, 2023 at 14:20 To: Andy Goryachev Cc: John Hendrikx , openjfx-dev@openjdk.org Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap Andy, John Hendrikx has given specific instances where this is breaking down already. The JavaDoc

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Martin Fox
14:48 > To: John Hendrikx > Cc: Andy Goryachev , openjfx-dev@openjdk.org > > Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap > > I’ve been digging around in the code to get some context on the existing > machinery for ordering event handler execution. I

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Andy Goryachev
: Andy Goryachev , openjfx-dev@openjdk.org Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap I’ve been digging around in the code to get some context on the existing machinery for ordering event handler execution. I haven’t had time to write up test cases so all of this is

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-16 Thread Andy Goryachev
think? -andy From: openjfx-dev mailto:openjfx-dev-r...@openjdk.org>> on behalf of Pedro Duque Vieira mailto:pedro.duquevie...@gmail.com>> Date: Saturday, October 7, 2023 at 14:05 To: openjfx-dev@openjdk.org<mailto:openjfx-dev@openjdk.org> mailto:openjfx-dev@openjdk.org>>

Re: [Request for Comments] Behavior / InputMap

2023-10-15 Thread Pedro Duque Vieira
n of skins? >- Would this proposal (BehaviorBase + InputMap) prevent us from moving >forward? > > > > What do you think? > > > > -andy > > > > > > > > *From: *openjfx-dev on behalf of Pedro > Duque Vieira > *Date: *Saturday, Oc

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-14 Thread Martin Fox
X that allows for replacing key bindings with a much nicer API >> already (in so far that is possible without having inside FX support). >> >> The general tone of the comments seems to be that Behaviors should be kept >> as implementation details -- they're not well de

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-12 Thread Andy Goryachev
I fully agree with you here, Martin. -andy From: Martin Fox Date: Thursday, October 12, 2023 at 09:31 To: Andy Goryachev Cc: John Hendrikx , openjfx-dev@openjdk.org Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap Andy, Speaking of the platform nuances – this

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-12 Thread Martin Fox
Andy, > Speaking of the platform nuances – this might be relevant to the ongoing > platform API discussion. Right now FX picks up nothing from the preferences > set by the user within the OS. You are right, macOS allows the user to > change key modifiers (for example, switch control and comma

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-11 Thread Andy Goryachev
(and got plenty, thanks!). Let’s see what else we could find. Thank you -andy From: Martin Fox Date: Wednesday, October 11, 2023 at 14:53 To: Andy Goryachev Cc: John Hendrikx , openjfx-dev@openjdk.org Subject: [External] : Re: [Request for Comments] Behavior / InputMap Andy, This might

Re: [Request for Comments] Behavior / InputMap

2023-10-11 Thread Martin Fox
not before next week. Martin > > From: openjfx-dev on behalf of Martin Fox > > Date: Wednesday, October 11, 2023 at 10:27 > To: John Hendrikx > Cc: openjfx-dev@openjdk.org > Subject: Re: [Request for Comments] Behavior / InputMap > > > On Oct 11, 2023, at 1:03

Re: [Request for Comments] Behavior / InputMap

2023-10-11 Thread Andy Goryachev
Martin Fox Date: Wednesday, October 11, 2023 at 10:27 To: John Hendrikx Cc: openjfx-dev@openjdk.org Subject: Re: [Request for Comments] Behavior / InputMap On Oct 11, 2023, at 1:03 AM, John Hendrikx wrote: After reading John's message I realize that the InputMap proposal doesn’t list

Re: [Request for Comments] Behavior / InputMap

2023-10-11 Thread Martin Fox
Michael Strauß <mailto:michaelstr...@gmail.com> >> Cc: openjfx-dev@openjdk.org <mailto:openjfx-dev@openjdk.org> >> <mailto:openjfx-dev@openjdk.org> >> Subject: Re: [Request for Comments] Behavior / InputMap >> >> Dear Michael: >> >> Her

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-10 Thread Andy Goryachev
Goryachev , openjfx-dev@openjdk.org Subject: [External] : Re: [Request for Comments] Behavior / InputMap On 09/10/2023 22:24, Andy Goryachev wrote: Dear John: Thank you for a very thoughtful analysis! I wanted to initiate a discussion, with the goal of making FX better. Let me try to respond to

Re: [Request for Comments] Behavior / InputMap

2023-10-10 Thread Michael Strauß
> Yes, one of the features the new design provides is ability to modify key > mappings by the user at runtime. So yes, not only it needs to be mutable, > but it also adds some APIs for exactly that. > I struggle to see a use case for this feature. I can imagine that there might be some use case

Re: [Request for Comments] Behavior / InputMap

2023-10-10 Thread John Hendrikx
On 09/10/2023 22:24, Andy Goryachev wrote: Dear John: Thank you for a very thoughtful analysis! I wanted to initiate a discussion, with the goal of making FX better.  Let me try to respond to your comments. The main odd thing that jumps out immediately is the fact that Behaviors and Input

Re: [Request for Comments] Behavior / InputMap

2023-10-09 Thread Andy Goryachev
find a scenario where things would definitely not work. What do you think? -andy From: openjfx-dev on behalf of John Hendrikx Date: Saturday, October 7, 2023 at 10:43 To: openjfx-dev@openjdk.org Subject: Re: [Request for Comments] Behavior / InputMap I've read the proposal. I think it

Re: [Request for Comments] Behavior / InputMap

2023-10-09 Thread Andy Goryachev
(BehaviorBase + InputMap) prevent us from moving forward? What do you think? -andy From: openjfx-dev on behalf of Pedro Duque Vieira Date: Saturday, October 7, 2023 at 14:05 To: openjfx-dev@openjdk.org Subject: Re: [Request for Comments] Behavior / InputMap I second the opinions of others

Re: [Request for Comments] Behavior / InputMap

2023-10-07 Thread Pedro Duque Vieira
I second the opinions of others that JavaFX is too closed which, I think, hinders the work of library and app developers. I wonder if the reasons that were used to make this design decision back when JavaFX was being created still hold true. Back in the beginning there were more developers involve

Re: [Request for Comments] Behavior / InputMap

2023-10-07 Thread John Hendrikx
I've read the proposal. I think it would be good to take a step back first and look at the classes and interfaces involved: Control, Behavior, InputMap, Skin -- the time is now to take a good look at these before making more public. They're currently very interwoven which is usually a sign th

Re: [External] : Re: [Request for Comments] Behavior / InputMap

2023-10-06 Thread Andy Goryachev
y, October 6, 2023 at 07:13 To: Andy Goryachev Cc: openjfx-dev@openjdk.org Subject: [External] : Re: [Request for Comments] Behavior / InputMap Hi Andy, I think the opaqueness of JavaFX controls is one of the greatest shortcomings of the framework, so I welcome an enhancement. Some thoughts: 1.

Re: [Request for Comments] Behavior / InputMap

2023-10-06 Thread Michael Strauß
Hi Andy, I think the opaqueness of JavaFX controls is one of the greatest shortcomings of the framework, so I welcome an enhancement. Some thoughts: 1. It seems that the behavior implementation is still hard-coded into the skin implementation. For example, TextFieldSkin uses TextFieldBehavior; i

Re: [Request for Comments] Behavior / InputMap

2023-10-05 Thread Robert Lichtenberger
Very much appreciated from my side. I can still remember hacking my way into the the InputMap of some controls to change unwanted behaviour. Generally speaking: Making JavaFX more open is (for me) more important than keeping it 100% backwards compatible / super stable. Thanks, Robert Licht

Re: [Request for Comments] Behavior / InputMap

2023-10-04 Thread Andy Goryachev
From: Andy Goryachev Date: Friday, September 29, 2023 at 15:44 To: openjfx-dev@openjdk.org Subject: [Request for Comments] Behavior / InputMap Dear fellow JavaFX developers: For some time now, we’ve been working to identify missing features in JavaFX that hinder application development

[Request for Comments] Behavior / InputMap

2023-09-29 Thread Andy Goryachev
Dear fellow JavaFX developers: For some time now, we’ve been working to identify missing features in JavaFX that hinder application development. We’ve been working on adding some of the missing features (for which we’ll have a separate announcement), but I feel that engaging wider community is