Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v6]

2025-03-05 Thread danielpeintner
On Wed, 5 Mar 2025 18:06:26 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called >> `ListenerManager` with improved semantics. >> >> # Behavior >> >> |Listener...|ExpressionHelper|ListenerManager| >> |---|---|---| >> |Invocation Order|In order

Re: RFR: 8341686: FX: Update copyright year in docs, readme files to 2025

2024-10-17 Thread danielpeintner
On Thu, 17 Oct 2024 05:58:31 GMT, Ambarish Rapte wrote: > Update Copyright year in these 3 doc files to 2025. I don't wanna bother you but I am surprised to see 2025 given we are still in 2024. The description of the issue [JDK-8341686](https://bugs.openjdk.org/browse/JDK-8341686) mentions als

Re: RFR: 8301121: RichTextArea Control (Incubator)

2024-08-02 Thread danielpeintner
On Wed, 31 Jul 2024 15:08:44 GMT, Andy Goryachev wrote: >> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java >> line 157: >> >>> 155: * @since 999 TODO >>> 156: */ >>> 157: public class RichTextArea extends Control { >> >> The *old* `TextFiel

Re: RFR: 8301121: RichTextArea Control (Incubator)

2024-07-31 Thread danielpeintner
On Tue, 30 Jul 2024 21:01:15 GMT, Andy Goryachev wrote: > Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v6]

2024-01-29 Thread danielpeintner
On Mon, 29 Jan 2024 14:38:20 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in comm

Re: RFR: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues [v3]

2022-09-21 Thread danielpeintner
On Wed, 21 Sep 2022 13:27:46 GMT, Michael Strauß wrote: >> I got this problem as well today. NPE as `runs` is null in line `359`. Does >> it make sense to first 'resolve' this by adding a simple null check and >> later we may try your other change which removes the call to >> `getParent().layo

Re: RFR: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues [v4]

2022-09-20 Thread danielpeintner
On Mon, 22 Aug 2022 09:46:24 GMT, Florian Kirmaier wrote: >> It's "a bit" complicated. >> In some situations, getRuns get's called because listeners on bounds are set. >> This causes TextFlow to layout to compute the runs. >> Afterward, the bounds of the parents get updated. >> This triggers a

Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE [v3]

2022-09-12 Thread danielpeintner
On Sun, 11 Sep 2022 19:30:18 GMT, Marius Hanl wrote: >> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` >> is set on a `ListView`. >> >> The following NPEs are fixed (all are also covered by exactly one test case): >> NPEs with null selection model: >> - Mouse click o

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v6]

2022-08-23 Thread danielpeintner
On Mon, 22 Aug 2022 21:08:39 GMT, Andy Goryachev wrote: >> The issue is caused by TreeTableRow incorrectly selected when cell selection >> mode is enabled. >> >> Changes: >> - modified TreeTableRow.updateSelection() > > Andy Goryachev has updated the pull request incrementally with two addition