On Fri, 11 Jul 2025 04:17:24 GMT, Prasanta Sadhukhan
wrote:
> Issue is when `JFXPanel `is used to embed some JavaFX components and when we
> drag something from swing or an external application and try to drop on a
> JavaFX component inside the JFXPanel, it doesn't accept th
On Tue, 15 Jul 2025 17:53:05 GMT, Kevin Rushforth wrote:
> > Maybe also update the description in this PR and the ticket?
>
> I added a note to the JBS Description.
>
> @prsadhuk Can you update the PR description when you fix the title?
@kevinrushforth Do you want me to overwrite the entire d
On Sun, 13 Jul 2025 08:52:31 GMT, Prasanta Sadhukhan
wrote:
>> Issue is when `JFXPanel `is used to embed some JavaFX components and when we
>> drag something from swing or an external application and try to drop on a
>> JavaFX component inside the JFXPanel, it doesn't
JDK side of DnD scheme.
> Also, to have a proper drop of the data, we get the focus owner from the
> JFXPanel scene and insert the text in the location pointed to by the mouse
> cursor.
>
> Regression test is already present in
> tests/manual/swing/DragDropOntoJavaFXCo
JDK side of DnD scheme.
> Also, to have a proper drop of the data, we get the focus owner from the
> JFXPanel scene and insert the text in the location pointed to by the mouse
> cursor.
>
> Regression test is already present in
> tests/manual/swing/DragDropOntoJavaFXCo
On Fri, 11 Jul 2025 16:21:39 GMT, Kevin Rushforth wrote:
>> modules/javafx.swing/src/main/java/com/sun/javafx/embed/swing/SwingDnD.java
>> line 203:
>>
>>> 201: javafx.embed.swing.JFXPanel jfxPanel =
>>> (javafx.embed.swing.JFXPanel)comp;
>>> 202:
>>> 203:
Issue is when `JFXPanel `is used to embed some JavaFX components and when we
drag something from swing or an external application and try to drop on a
JavaFX component inside the JFXPanel, it doesn't accept the drop showing
"block" sign suggesting DnD is blocked.
The problem is in both drag an
Vote: Yes
Regards
Prasanta
On 29-05-2025 01:21, Kevin Rushforth wrote:
I hereby nominate Alexander Zuev [1] to OpenJFX Committer.
Alexander is a member of the JavaFX team at Oracle who has contributed
10 commits [2] to OpenJFX.
Votes are due by June 11, 2025 at 20:00 UTC.
Only current OpenJ
On Fri, 13 Dec 2024 19:46:54 GMT, Kevin Rushforth wrote:
> This PR fixes a latent test bug in test bug in
> `SwingNodePlatformExitCrashTest` by setting a flag to skip shutdown rather
> than relying on a quirk of JUnit 5.8.1.
>
> I discovered this while testing PR #1662 which updates JUnit to 5
On Wed, 30 Oct 2024 18:21:27 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swing
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has upda
On Mon, 28 Oct 2024 15:01:20 GMT, Prasanta Sadhukhan
wrote:
> When AWT toolkit is started first for it to own the "NSApplication" and then
> FX toolkit is started and shutdown by calling `Platform.exit` and then Swing
> Dialog is tried to be created, then it is seen t
When AWT toolkit is started first for it to own the "NSApplication" and then FX
toolkit is started and shutdown by calling `Platform.exit` and then Swing
Dialog is tried to be created, then it is seen that the application crashes as
the AWT dialog tries to create the underlying Window as a child
On Thu, 17 Oct 2024 07:43:28 GMT, Prasanta Sadhukhan
wrote:
> SwingNodePlatformExitCrashTest lists
> [JDK-8190329](https://bugs.openjdk.org/browse/JDK-8190329) as the reason it
> is skipped. However, the correct bug ID is the newly filed
> [JDK-8340849](https://bugs.openjdk.or
SwingNodePlatformExitCrashTest lists
[JDK-8190329](https://bugs.openjdk.org/browse/JDK-8190329) as the reason it is
skipped. However, the correct bug ID is the newly filed
[JDK-8340849](https://bugs.openjdk.org/browse/JDK-8340849)
-
Commit messages:
- 8340850: Wrong bug ID listed
On Tue, 15 Oct 2024 03:18:09 GMT, Prasanta Sadhukhan
wrote:
> While implementing [JDK-8339517](https://bugs.openjdk.org/browse/JDK-8339517)
> to eliminate native access warnings by passing "--enable-native-access" for
> the three JavaFX modules with native code (javafx.gra
ingNode tests are running ok without any native
> warning
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Revert platformimpl change
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1600/files
- new: h
ingNode tests are running ok without any native
> warning
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Move native method to Application
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1600/files
While implementing [JDK-8339517](https://bugs.openjdk.org/browse/JDK-8339517)
to eliminate native access warnings by passing "--enable-native-access" for the
three JavaFX modules with native code (javafx.graphics, javafx.media, and
javafx.web), it was found that the Swing interop code in javafx
On Thu, 29 Aug 2024 15:56:59 GMT, Kevin Rushforth wrote:
>> A Swing / FX interop app will crash if an application creates a new AWT /
>> Swing window after calling Platform.exit. The root cause of the crash is
>> that AWT caches the JNI env pointer for the AppKit thread, and assumes that
>> it
On Mon, 26 Aug 2024 21:11:03 GMT, Kevin Rushforth wrote:
> A Swing / FX interop app will crash if an application creates a new AWT /
> Swing window after calling Platform.exit. The root cause of the crash is that
> AWT caches the JNI env pointer for the AppKit thread, and assumes that it is
>
On Mon, 1 Jul 2024 20:43:44 GMT, Andy Goryachev wrote:
> Kevin is right, this fix does not solve the issue mentioned in the ticket.
> Once the fxPanel is added back, its content is not visible. Does not matter
> whether removing/adding happens at startup or the button event handler.
>
> (attac
ntainer for active JFXPanel) has been
> reset/deleted which is done when `EmbeddedScene.dispose` is called during
> removeNotify and abstain from updating the scene state
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
On Fri, 28 Jun 2024 08:49:49 GMT, Prasanta Sadhukhan
wrote:
> Adding, then removing, and then adding a JFXPanel to the same component in
> the Swing scene graph leads to a NullPointerException in GlassScene because
> the sceneState is null.
> Removing JFXPanel calls JFXPanel.
ntainer for active JFXPanel) has been
> reset/deleted which is done when `EmbeddedScene.dispose` is called during
> removeNotify and abstain from updating the scene state
Prasanta Sadhukhan has updated the pull request incrementally with two
additional commits since the last revision:
On Mon, 1 Jul 2024 05:44:21 GMT, Prasanta Sadhukhan
wrote:
>> Can you add an automated test to cover this fix?
>>
>> Worth noting, this won't fully solve the problem that the reporter of this
>> bug filed. The null check will prevent the NPE, but the scene will
On Fri, 28 Jun 2024 14:12:37 GMT, Kevin Rushforth wrote:
> To allow removing and then re-adding the `JFXPanel`, we would need to not
> call `Window.hide` when the `JFXPanel` is removed.
I am not sure if this is a problem as just as `JFXPanel.removeNotify` does
`Window.hide` but at the same tim
Adding, then removing, and then adding a JFXPanel to the same component in the
Swing scene graph leads to a NullPointerException in GlassScene because the
sceneState is null.
Removing JFXPanel calls JFXPanel.removeNotify which calls Window.hide which
calls SceneHelper.disposePeer -> Scene.dispos
On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Fri, 1 Mar 2024 17:11:00 GMT, Kevin Rushforth wrote:
>> FYI: after merging this and #1384 together all I see in the build log are 4
>> native warnings (on macOS):
>>
>>
>> /Users/angorya/Projects/jfx-1/jfx/rt/modules/javafx.graphics/src/main/native-prism-es2/macosx/MacOSXWindowSystemInterfa
On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Mon, 22 Jan 2024 09:01:10 GMT, Prasanta Sadhukhan
wrote:
> Test fails with
>
> JFXPanelHiDPITest > testScale FAILED
> java.lang.NullPointerException: Cannot invoke
> "java.awt.image.BufferedImage.getWidth()" because "pixelsIm" is null
>
>
th invokeLater.
> FIx is to make it run with invokeAndWait so that it waits for the scene to be
> created..
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Use Util.runAndWait
-
Changes:
- all: https://
th invokeLater.
> FIx is to make it run with invokeAndWait so that it waits for the scene to be
> created..
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Use Platform.runAndWait
-
Changes:
- all: https://
On Mon, 22 Jan 2024 09:01:10 GMT, Prasanta Sadhukhan
wrote:
> Test fails with
>
> JFXPanelHiDPITest > testScale FAILED
> java.lang.NullPointerException: Cannot invoke
> "java.awt.image.BufferedImage.getWidth()" because "pixelsIm" is null
>
>
th invokeLater.
> FIx is to make it run with invokeAndWait so that it waits for the scene to be
> created..
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Use Platform.runAndWait
-
Changes:
- all: https://
Test fails with
JFXPanelHiDPITest > testScale FAILED
java.lang.NullPointerException: Cannot invoke
"java.awt.image.BufferedImage.getWidth()" because "pixelsIm" is null
because scenePeer is not yet created as the test is run with invokeLater.
FIx is to make it run with invokeAndWait so that
On Thu, 18 Jan 2024 07:28:57 GMT, Prasanta Sadhukhan
wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
>> processed on the JavaFX application thread instead of the AWT EventQueue
>> thread. This PR adds the runAndWait() calls to do that.
&g
On Tue, 16 Jan 2024 17:59:42 GMT, Martin Fox wrote:
> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
> processed on the JavaFX application thread instead of the AWT EventQueue
> thread. This PR adds the runAndWait() calls to do that.
>
> This would be difficult to te
On Tue, 16 Jan 2024 17:59:42 GMT, Martin Fox wrote:
> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
> processed on the JavaFX application thread instead of the AWT EventQueue
> thread. This PR adds the runAndWait() calls to do that.
>
> This would be difficult to te
On Mon, 15 Jan 2024 16:11:08 GMT, Kevin Rushforth wrote:
> Clean backport of a safe fix for this critical deadlock bug to the jfx22
> stabilization branch during RDP1.
Marked as reviewed by psadhukhan (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1334#pullrequestreview
On Thu, 11 Jan 2024 23:54:13 GMT, Kevin Rushforth wrote:
>> As described in the JBS bug, there is a long-standing deadlock that happens
>> on macOS between the AWT EDT and the JavaFX Application thread (which on
>> macOS is the AppKit thread) when processing Input Method Events (IME) in a
>> W
On Thu, 9 Nov 2023 03:43:48 GMT, Prasanta Sadhukhan
wrote:
> Manual regression test for 8252255: Blurry rendering of SwingNode with HiDPI
> scaling in JavaFX is added
This pull request has now been integrated.
Changeset: a1036b26
Author:Prasanta Sadhukhan
URL:
Manual regression test for 8252255: Blurry rendering of SwingNode with HiDPI
scaling in JavaFX is added
-
Commit messages:
- 8303826: Add FX test for JDK-8252255
- 8303826: Add FX test for JDK-8252255
Changes: https://git.openjdk.org/jfx/pull/1282/files
Webrev: https://webrevs.op
On Thu, 2 Nov 2023 06:04:23 GMT, Prasanta Sadhukhan
wrote:
> A manual regression test for JFXPanel orientation fix in
> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
This pull request has now been integrated.
Changeset: 29f9c4d3
Author:Prasanta Sadhukha
On Mon, 6 Nov 2023 06:06:35 GMT, Prasanta Sadhukhan
wrote:
>> A manual regression test for JFXPanel orientation fix in
>> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> add
On Sat, 4 Nov 2023 13:48:48 GMT, Kevin Rushforth wrote:
> make the test window smaller so they don't overlap
Done
> Maybe set the X and Y of the instruction window
Although it is probably not required now, but can you please specify how to do
it for my future reference as I dont see Scene accep
> A manual regression test for JFXPanel orientation fix in
> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
Prasanta Sadhukhan has updated the pull request incrementally with two
additional commits since the last revision:
- Formatting
- Modify windo
A manual regression test for JFXPanel orientation fix in
[JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
-
Commit messages:
- Test fix
- Test fix
Changes: https://git.openjdk.org/jfx/pull/1276/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1276&range=0
On Thu, 26 Oct 2023 09:34:17 GMT, Prasanta Sadhukhan
wrote:
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the valu
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
On Tue, 31 Oct 2023 16:13:57 GMT, Prasanta Sadhukhan
wrote:
>> FX Nodes embedded in a Swing JFXPanel does not track the component
>> orientation and FX nodes remain unaffected when component orientation
>> changes.
>> Fix made sure JavaFX scene embedded in a JFXPanel
On Tue, 31 Oct 2023 15:54:00 GMT, Andy Goryachev wrote:
> What would the behavior of a JLabel in a JPanel be when the JFrame is set
> back to UNKNOWN?
It sets it back to LTR it is toggled from RIGHT_TO_LEFT to UNNOWN.
So, I updated PR to set JFXPanel to LTR for UNKNOWN..If set to INHERIT, then
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
On Mon, 30 Oct 2023 14:00:56 GMT, Prasanta Sadhukhan
wrote:
>> FX Nodes embedded in a Swing JFXPanel does not track the component
>> orientation and FX nodes remain unaffected when component orientation
>> changes.
>> Fix made sure JavaFX scene embedded in a JFXPanel
On Tue, 31 Oct 2023 15:36:20 GMT, Andy Goryachev wrote:
> > I expect RTL because INHERIT is unsupported so it will retain the existing
> > orientation,
>
> Why existing and not the initial?
Tha tis grey area which is not mentioned in the spec so I think retaining
existing is the appropriate a
On Tue, 31 Oct 2023 15:07:32 GMT, Andy Goryachev wrote:
> > I think it is expected to retain RTL in this case..
>
> Ok, INHERIT is not supported, but why do you expect RTL? Shouldn't it go back
> to UNKNOWN and therefore LTR?
>
> ```
> public static final
> [ComponentOrientation](https://docs
On Mon, 30 Oct 2023 15:23:45 GMT, Kevin Rushforth wrote:
>> Yes, initialization helped..Updated the PR...
>> Also, speaking of regression test, I need some time to create one.. Will it
>> be ok to push the fix if found to be ok and I work on the test
>> simultaneously as a separate JBS test iss
On Mon, 30 Oct 2023 14:00:56 GMT, Prasanta Sadhukhan
wrote:
>> FX Nodes embedded in a Swing JFXPanel does not track the component
>> orientation and FX nodes remain unaffected when component orientation
>> changes.
>> Fix made sure JavaFX scene embedded in a JFXPanel
On Mon, 30 Oct 2023 12:53:07 GMT, Kevin Rushforth wrote:
>> I have made the suggested changes and updated the PR.
>> But it seems the orientation of the text in the test attached in JBS is at
>> the middle initially (and not at LTR or RTL) and it only begins to track the
>> orientation after 1
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
On Sat, 28 Oct 2023 18:25:53 GMT, Kevin Rushforth wrote:
>> I have tried to put in place what you suggested. Can you please take a look
>> at the PR and see if it's in the right direction and suggest further.
>> I have few doubts
>>
>> - It seems JFXPanel call EmbeddedStage interface methods an
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
On Fri, 27 Oct 2023 16:55:30 GMT, Kevin Rushforth wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code optimize
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFX
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
On Thu, 26 Oct 2023 18:16:26 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimization
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFX
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
On Thu, 26 Oct 2023 15:31:02 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimization
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFX
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the
FX Nodes embedded in a Swing JFXPanel does not track the component orientation
and FX nodes remain unaffected when component orientation changes.
Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value from
the JFXPanel.
-
Commit messages:
- 8317836: FX nodes emb
On Fri, 13 Oct 2023 03:23:42 GMT, Prasanta Sadhukhan
wrote:
> Corrected the typo
This pull request has now been integrated.
Changeset: 4604e873
Author: Prasanta Sadhukhan
URL:
https://git.openjdk.org/jfx/commit/4604e87372adf3842529c1b3640bdb4424867e3d
Stats: 1 line in 1 f
Corrected the typo
-
Commit messages:
- Typo fix
Changes: https://git.openjdk.org/jfx/pull/1260/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1260&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8318059
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch:
On Fri, 1 Sep 2023 03:16:11 GMT, Prasanta Sadhukhan
wrote:
> Added automated test for 8262518:SwingNode.setContent does not close previous
> content, resulting in memory leak
This pull request has now been integrated.
Changeset: eb7de72d
Author:Prasanta Sadhukhan
URL:
On Fri, 1 Sep 2023 14:31:49 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Better failure detection
>
> tests/system/src/tes
On Fri, 1 Sep 2023 14:38:16 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/javafx/embed/swing/SwingNodeContentMemoryLeakTest.java
>> line 116:
>>
>>> 114: System.out.println("iteration " + count + " Panels in
>>> memory: "
>>> 115:
> Added automated test for 8262518:SwingNode.setContent does not close previous
> content, resulting in memory leak
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Better failure detection
-
Changes:
Added automated test for 8262518:SwingNode.setContent does not close previous
content, resulting in memory leak
-
Commit messages:
- jckeck fix
- 8315317: Add test for JDK-8262518
Changes: https://git.openjdk.org/jfx/pull/1228/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&p
On Fri, 25 Aug 2023 03:36:53 GMT, Prasanta Sadhukhan
wrote:
>> Issue is when setting the content of a SwingNode, the old content is not
>> garbage collected owing to the fact
>> JLightweightFrame is never being released by SwingNodeDisposer
>>
>> The SwingNodeDis
> Due to transient datatype of scenePeer, it can become null which can result
> in NPE in scenarios where scene is continuously been reset and set, which
> warrants a null check, as is done in other places for the same variable.
Prasanta Sadhukhan has updated the pull request increment
> Due to transient datatype of scenePeer, it can become null which can result
> in NPE in scenarios where scene is continuously been reset and set, which
> warrants a null check, as is done in other places for the same variable.
Prasanta Sadhukhan has updated the pull request with a n
On Mon, 28 Aug 2023 22:57:44 GMT, Kevin Rushforth wrote:
> Is it possible to write an automated test?
oops..missed this..i can definitely try..maybe in upcoming test-sprint..
-
PR Comment: https://git.openjdk.org/jfx/pull/1219#issuecomment-1696740917
On Tue, 22 Aug 2023 09:54:11 GMT, Prasanta Sadhukhan
wrote:
> Issue is when setting the content of a SwingNode, the old content is not
> garbage collected owing to the fact
> JLightweightFrame is never being released by SwingNodeDisposer
>
> The SwingNodeDisposer holds an hard
On Thu, 24 Aug 2023 22:30:04 GMT, John Hendrikx wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc, dispose
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/Swin
tion
>
> Modified `SwingNode.setContentImpl` function to use a WeakReference to
> properly release the memory.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc, dispose
-
Changes:
- all: https
On Wed, 23 Aug 2023 14:57:31 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> DisposerRecord leak fix
>
> modules/javafx.swing/src/main/java/javafx/embed
tion
>
> Modified `SwingNode.setContentImpl` function to use a WeakReference to
> properly release the memory.
Prasanta Sadhukhan has updated the pull request incrementally with two
additional commits since the last revision:
- javadoc, null check
- javadoc, null check
---
tion
>
> Modified `SwingNode.setContentImpl` function to use a WeakReference to
> properly release the memory.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
DisposerRecord leak fix
-
Changes:
- all:
On Wed, 23 Aug 2023 10:13:32 GMT, John Hendrikx wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimize without WeakReference
>
> modules/javafx.swing/src/main/java/com/sun/ja
On Tue, 22 Aug 2023 09:54:11 GMT, Prasanta Sadhukhan
wrote:
> Issue is when setting the content of a SwingNode, the old content is not
> garbage collected owing to the fact
> JLightweightFrame is never being released by SwingNodeDisposer
>
> The SwingNodeDisposer holds an hard
tion
>
> Modified `SwingNode.setContentImpl` function to use a WeakReference to
> properly release the memory.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Optimize without WeakReference
---
Issue is when setting the content of a SwingNode, the old content is not
garbage collected owing to the fact
JLightweightFrame is never being released by SwingNodeDisposer
The SwingNodeDisposer holds an hard pointer to the JLightweightFrame that
prevents its collection
Modified `SwingNode.setCo
On Thu, 6 Jul 2023 13:10:44 GMT, Prasanta Sadhukhan
wrote:
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindo
On Tue, 4 Jul 2023 05:54:54 GMT, Prasanta Sadhukhan
wrote:
> When Japanse (IME on) is inputted to the TextFIeld, which is on JFXPanel,
> small window for inputting appears on top-left side of screen
>
> ![image](https://github.com/openjdk/jfx/assets/43534309/65833d59-52
On Tue, 15 Aug 2023 14:41:16 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Duplicate code removal
>
> modules/javafx.swing/src/main/java/javafx/embe
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementa
On Thu, 3 Aug 2023 18:05:52 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Call updateSceneState with lock and in FX thread
>
> src="https://gith
On Mon, 7 Aug 2023 08:52:01 GMT, John Hendrikx wrote:
> Are you sure it works correctly on Windows now?
I have tested EmbeddedFrameBug in windows10 with primary scale 1.25 and
secondary scale 1.75 and it worked for me..
-
PR Comment: https://git.openjdk.org/jfx/pull/1171#issuecomm
On Mon, 7 Aug 2023 07:56:27 GMT, John Hendrikx wrote:
> > > both windows (using EmbeddedFrameBug class listed earlier) shows O100%
> > > for primary retina screen (should be 200%).
> >
> >
> > @hjohn Seems like @andy-goryachev-oracle is telling it regressed after
> > `updateSceneState` integr
On Thu, 27 Jul 2023 16:59:59 GMT, Andy Goryachev wrote:
> I would love to review this, but for some reason, I could not get Japanese
> IME to work on my windows 11...
Does it work now?
or Can anyone else review this please?
-
PR Comment: https://git.openjdk.org/jfx/pull/1169#issu
1 - 100 of 144 matches
Mail list logo
