On Sat, 21 Jun 2025 23:37:13 GMT, Michael Strauß wrote:
>> The window button states (disabled/hidden) of extended stages with a
>> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we
>> would expect from the OS (Windows and Linux). To figure out what we would
>> expect
On Tue, 17 Jun 2025 00:41:54 GMT, Michael Strauß wrote:
>> The window button states (disabled/hidden) of extended stages with a
>> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we
>> would expect from the OS (Windows and Linux). To figure out what we would
>> expect
On Thu, 12 Jun 2025 21:53:33 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add
On Thu, 12 Jun 2025 19:39:30 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Tue, 10 Jun 2025 02:51:34 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> onl
On Thu, 5 Jun 2025 00:50:30 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> rena
On Wed, 4 Jun 2025 14:48:31 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> enab
On Tue, 20 May 2025 19:01:26 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Thu, 15 May 2025 18:56:14 GMT, Michael Strauß wrote:
>> Some platform preference changes can trigger the emission of multiple
>> notifications. For example, when switching from a high-contrast theme on
>> Windows to the regular theme, the following notifications are emitted (log
>> can be v
On Wed, 14 May 2025 23:00:29 GMT, Michael Strauß wrote:
> The platform preferences API does not pick up the correct `UIColor` values
> when changing from a high-contrast Windows theme to another high-contrast
> theme.
>
> The reason is that the implementation incorrectly assumes that changing
On Fri, 2 May 2025 11:46:12 GMT, Michael Strauß wrote:
> > Would it be feasible to ensure the minium window width is large enough by
> > default, and allowing to turn this off when manual clipping is implemented
> > instead?
>
> It's probably a bit hard with the API around `Stage.minWidth` and
On Fri, 2 May 2025 10:32:42 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> simp
On Sat, 26 Apr 2025 19:36:45 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add
On Thu, 24 Apr 2025 17:40:38 GMT, Michael Strauß wrote:
> Maybe you used a layout pane inside the `HeaderBar`, and set
> `HeaderBar.draggable = true` for the layout pane? This would then apply to
> the entire subtree of the pane, including the `MenuBar`.
Yes, the controls are in an `HBox` with
On Thu, 24 Apr 2025 14:36:33 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 113:
>>
>>> 111: * of the {@code Scene} to remain easily recognizable.
>>> Applications should set the scene fill to a color
>>> 112: * that matches the b
On Thu, 24 Apr 2025 15:07:10 GMT, Michael Strauß wrote:
>> Ah, so I think I misunderstood this. Maybe change "is adjusted to" to "is
>> adjusted to match" or "is bound to" so it's clear the fill color is used as
>> the background, and not something else based on it. Also, add "elsewhere"
>> af
On Thu, 24 Apr 2025 14:36:52 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.h line 53:
>>
>>> 51: BOOLisDecorated;
>>> 52: BOOLisResizable;
>>> 53: BOOLisStandardButtonsVisible;
>>
>> showSt
On Thu, 24 Apr 2025 14:36:35 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 117:
>>
>>> 115: * Custom header buttons
>>> 116: * If more control over the header buttons is desired,
>>> applications can opt out of the default header
On Sun, 23 Mar 2025 08:56:43 GMT, Michael Strauß wrote:
>> We generally use "Behavior" in the context of controls. Although not wrong,
>> I also think another name might be better. Maybe "Controller"? Or "Manager"?
>> Or ...
>
> After contemplating for a while, I still think that "Behavior" is
On Tue, 15 Apr 2025 10:56:31 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> doc
On Mon, 25 Nov 2024 17:49:37 GMT, Michael Strauß wrote:
>> When the initial value of a styleable property is not specified in a
>> stylesheet, no transition is started:
>>
>> .button {
>> transition: -fx-opacity 1s;
>> }
>>
>> .button:hover {
>> -fx-opacity: 0.5
On Sun, 1 Sep 2024 12:31:06 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
On Mon, 24 Jun 2024 22:10:38 GMT, Markus Mack wrote:
> This PR is a fix for another IOOBE that I discovered while working on #1476.
>
> The PR simplifies the code for adding a series that already contains data by
> adding the data points one-by-one.
> As far as I can see
On Mon, 15 Jul 2024 16:42:33 GMT, Andy Goryachev wrote:
> I am going to ask this question - unrelated to this PR, but in the context of
> this PR.
>
> Consider the case of a context menu, where the application needs to know the
> data point from the screen/local coordinates.
>
> Currently, we
On Mon, 15 Jul 2024 16:32:58 GMT, Andy Goryachev wrote:
>> Markus Mack has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix "negative" style class when series is changed
>
> modules/javafx.contro
g the duplicate data items resulting from
> multiplying by 0.
> Without this change `testSeriesRemoveAnimatedStyleClasses` would fail because
> it counts the number of plot children, where the duplicates are now removed.
Markus Mack has updated the pull request with a new target base
On Sat, 13 Jul 2024 10:00:31 GMT, Markus Mack wrote:
>> This PR is a fix for another IOOBE that I discovered while working on #1476.
>>
>> The PR simplifies the code for adding a series that already contains data by
>> adding the data points one-by-one.
>> As f
On Fri, 12 Jul 2024 15:54:24 GMT, Markus Mack wrote:
>> This PR is a fix for another IOOBE that I discovered while working on #1476.
>>
>> The PR simplifies the code for adding a series that already contains data by
>> adding the data points one-by-one.
>> As f
g the duplicate data items resulting from
> multiplying by 0.
> Without this change `testSeriesRemoveAnimatedStyleClasses` would fail because
> it counts the number of plot children, where the duplicates are now removed.
Markus Mack has updated the pull request incrementally with one add
g the duplicate data items resulting from
> multiplying by 0.
> Without this change `testSeriesRemoveAnimatedStyleClasses` would fail because
> it counts the number of plot children, where the duplicates are now removed.
Markus Mack has updated the pull request with a new target base du
On Mon, 24 Jun 2024 22:10:38 GMT, Markus Mack wrote:
> This PR is a fix for another IOOBE that I discovered while working on #1476.
>
> The PR simplifies the code for adding a series that already contains data by
> adding the data points one-by-one.
> As far as I can see
I'd say this is a good idea. Both variants are good, we might want to
mention CSS in the first one, though.
Not sure how others do it, but I regularly struggle to find out which
code properties correspond to which CSS styles. This is particularly the
case for names like "background", "border",
On Thu, 27 Jun 2024 20:22:24 GMT, Markus Mack wrote:
> This PR fixes the placement of `BarChart` bars and category tick marks,
> particularly when adding data / multiple series and enabling animations.
> It covers all cases mentioned in the JBS ticket and adds a unit test.
>
&g
;s a test for this situation as well.
>
> Note this does not fix
> [JDK-8334873](https://bugs.openjdk.org/browse/JDK-8334873) where bars get
> stuck while having different widths. There seem to be additional issues which
> seem not directly related to the changed code and are probabl
This PR fixes the placement of `BarChart` bars and category tick marks,
particularly when adding data / multiple series and enabling animations.
It covers all cases mentioned in the JBS ticket and adds a unit test.
The settable `barGap` and `categoryGap` now should also behave as expected.
There
On Tue, 25 Jun 2024 15:14:14 GMT, Markus Mack wrote:
> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
> mark layout code in subclasses) is called during `Chart` `Axis` layout when
> needed.
> Previously, it was only called when tick mark length or range
Values, which would need to be made at least
> package-private however (with a shim). This implementation checks the tick
> mark `Path` shape instead, which is already publicly accessible (but could be
> considered an implementation detail).
Markus Mack has updated the pull request incr
On Tue, 25 Jun 2024 22:48:26 GMT, Marius Hanl wrote:
>> Markus Mack has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup imports
>> - add clarifying comment to test
>
> modules/javafx.controls/s
On Tue, 25 Jun 2024 21:51:36 GMT, Andy Goryachev wrote:
>> I think we need to create that as it turned out it's not the same as the
>> minor tick problem fixed by this PR.
>
> but wait: this may not be a different issue. I see a slightly different
> behavior relative to the master branch:
>
>
On Tue, 25 Jun 2024 21:43:58 GMT, Andy Goryachev wrote:
>> yes, the BarChart issue (which I actually want to get fixed) will need
>> additional fixes in other classes. I could add those to this PR, but
>> probably it's best to handle them in another ticket+PR to keep this PR
>> affecting all `
Values, which would need to be made at least
> package-private however (with a shim). This implementation checks the tick
> mark `Path` shape instead, which is already publicly accessible (but could be
> considered an implementation detail).
Markus Mack has updated the pull request incre
On Tue, 25 Jun 2024 20:06:29 GMT, Andy Goryachev wrote:
>> Markus Mack has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup imports
>> - add clarifying comment to test
>
> modules/javafx.contr
This PR ensures the `tickMarksUpdated()` method (overriden with minor tick mark
layout code in subclasses) is called during `Chart` `Axis` layout when needed.
Previously, it was only called when tick mark length or range was changed,
which is not happening during axis animations, causing minor ti
This PR is a fix for another IOOBE that I discovered while working on #1476.
The PR simplifies the code for adding a series that already contains data by
adding the data points one-by-one.
As far as I can see no attempt was previously made to optimize the bulk
operation except for some trivial O
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've add
On Fri, 21 Jun 2024 16:11:52 GMT, Markus Mack wrote:
> This PR makes the `XYChart` axes properties return the correct parent XYChart
> object.
This pull request has now been integrated.
Changeset: 17c2dba0
Author:Markus Mack
Committer: Andy Goryachev
URL:
https://git.openj
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s jav
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've add
e previous code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with one add
On Fri, 21 Jun 2024 22:07:22 GMT, Andy Goryachev wrote:
>> Markus Mack has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> testAddingDataAtIndex & fix
>
> modules/javafx.controls/src/main/java/javafx/sce
On Fri, 21 Jun 2024 15:22:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've add
e previous code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with
On Fri, 21 Jun 2024 16:11:52 GMT, Markus Mack wrote:
> This PR makes the `XYChart` axes properties return the correct parent XYChart
> object.
in `StackedAreaChart` there's another one
-
PR Comment: https://git.openjdk.org/jfx/pull/1485#issuecomment-2183103384
> This PR makes the `XYChart` axes properties return the correct parent XYChart
> object.
Markus Mack has updated the pull request incrementally with one additional
commit since the last revision:
Set correct bean for properties in AreaChart / StackedAreaChart
-
C
This PR makes the `XYChart` axes properties return the correct parent XYChart
object.
-
Commit messages:
- XYChart: Set correct bean of axes properties
Changes: https://git.openjdk.org/jfx/pull/1485/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1485&range=00
Issue: htt
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've add
e previous code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've add
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've add
On Thu, 20 Jun 2024 17:59:13 GMT, Andy Goryachev wrote:
>> You'll need to add an additional point after adding the one with duplicate
>> categories to see the exception in the console. Using the "Add Point" button
>> in the monkey tester after using the context menu entry should reproduce the
On Thu, 20 Jun 2024 16:52:49 GMT, Andy Goryachev wrote:
>> However, I don't see the issue if I just add a duplicate data point after
>> the chart is rendered (the code jumps to line 218 (edit: 216, sorry) in the
>> master branch).
>>
>> This makes me think that perhaps the fix should include f
e previous code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s jav
This PR provides the test case given in the JBS issue, and a simple fix for the
index calculation when inserting data after previous data with duplicate
categories.
Also, I've added a comment to `BarChart`s javadoc, clarifying the behavior that
was apparently assumed (but broken) previously.
T
On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://www.w3.org/TR/css-transitions-1/).
>>
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471
>>
>> ### Limitations
>> This implementation supports both sho
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote:
> This PR fixes a bug
> ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was
> introduced with #394, which changed the following line in the
> `NotifyTouchInput` function (ViewContainer.cpp):
>
> - const bool isDirect =
I'd love to see this feature in JavaFX. This would allow for much
cleaner (and better reusable) implementations of modern-looking UI which
I'd like to have for current and future JavaFX projects. In the current
state of JavaFX, you'd usually need to roll your own custom control
skins which is n
67 matches
Mail list logo
